Skip to content

Fix/issue#32 should not show debug preview pannel when preview is disable #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmtrKovalenko merged 4 commits into from
Aug 4, 2025
Merged

Fix/issue#32 should not show debug preview pannel when preview is disable #55

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5a82a6
chore: autgenerate vimdoc
github-actions[bot] Aug 4, 2025
f13acb2
Merge branch 'dmtrKovalenko:main' into main
dinhmai74 Aug 4, 2025
617a06d
chore: should merge main config with opts when calling open with params
dinhmai74 Aug 4, 2025
135480a
fix: issue#32: hide debug preview panel base on enable_preview opt
dinhmai74 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions lua/fff/picker_ui.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@ function M.create_ui()

if not M.state.ns_id then M.state.ns_id = vim.api.nvim_create_namespace('fff_picker_status') end

local debug_enabled = main.config and main.config.debug and main.config.debug.show_scores
local debug_enabled_in_preview = M.enabled_preview()
and main.config
and main.config.debug
and main.config.debug.show_scores

local width = math.floor(vim.o.columns * config.width)
local height = math.floor(vim.o.lines * config.height)
Expand All @@ -62,7 +65,7 @@ function M.create_ui()

local file_info_height = 0
local preview_height = list_height
if debug_enabled then
if debug_enabled_in_preview then
file_info_height = 10 -- Fixed height of 10 lines for file info
preview_height = list_height - file_info_height -- No subtraction needed - borders are handled by window positioning
end
Expand All @@ -72,7 +75,7 @@ function M.create_ui()
M.state.list_buf = vim.api.nvim_create_buf(buf_opts[1], buf_opts[2])
if M.enabled_preview() then M.state.preview_buf = vim.api.nvim_create_buf(buf_opts[1], buf_opts[2]) end

if debug_enabled then
if debug_enabled_in_preview then
M.state.file_info_buf = vim.api.nvim_create_buf(buf_opts[1], buf_opts[2])
else
M.state.file_info_buf = nil
Expand All @@ -90,7 +93,7 @@ function M.create_ui()
title_pos = 'left',
})

if debug_enabled then
if debug_enabled_in_preview then
M.state.file_info_win = vim.api.nvim_open_win(M.state.file_info_buf, false, {
relative = 'editor',
width = preview_width,
Expand All @@ -106,8 +109,8 @@ function M.create_ui()
M.state.file_info_win = nil
end

local preview_row = debug_enabled and (row + file_info_height + 3) or (row + 1)
local preview_height_adj = debug_enabled and preview_height or (list_height + 2)
local preview_row = debug_enabled_in_preview and (row + file_info_height + 3) or (row + 1)
local preview_height_adj = debug_enabled_in_preview and preview_height or (list_height + 2)

if M.enabled_preview() then
M.state.preview_win = vim.api.nvim_open_win(M.state.preview_buf, false, {
Expand Down Expand Up @@ -1040,7 +1043,7 @@ function M.open(opts)
end
end

M.state.config = main.config
M.state.config = vim.tbl_deep_extend('force', main.config or {}, opts or {})

if not M.create_ui() then
vim.notify('Failed to create picker UI', vim.log.levels.ERROR)
Expand Down
Loading