Fix signout route#343
Open
drupsys wants to merge 2 commits into
Open
Conversation
Owner
|
Thanx! I will test and verify that everything is working as excpected! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, thanks for this briliant tool, please note I haven't written any applications in kotlin before and this is a very quick fix.
Current implementation of signout is not removing auth0 session browser cookies for the user, meaning, currently if the user returns to the application imidiately after signing out they will not be required to sign back in through auth0 single sign on, they will just get access to the app.
expected behaviour:
user signout -> user redirected to logout url -> user returns to application -> user is required to authenticate though auth0 signle sign on -> user is redirected to the application
actual behaviour:
user signout -> user redirected to logout url -> user returns to application -> user is assumed to be logged in