NullReferenceException fixes.

Author: dimarobert

DNN Platform/DotNetNuke.Web.Mvc/Framework/Modules/ModuleApplication.cs

@@ -167,7 +167,6 @@ public virtual async Task<ModuleRequestResult> ExecuteRequestAsync(ModuleRequest
             {
                 // Check if the controller supports IDnnController
                 var moduleController = controller as IDnnController;
-                moduleController.IsAsync = true;
 
                 // If we couldn't adapt it, we fail.  We can't support IController implementations directly :(
                 // Because we need to retrieve the ActionResult without executing it, IController won't cut it
@@ -176,6 +175,8 @@ public virtual async Task<ModuleRequestResult> ExecuteRequestAsync(ModuleRequest
                     throw new InvalidOperationException("Could Not Construct Controller");
                 }
 
+                moduleController.IsAsync = true;
+
                 moduleController.ValidateRequest = false;
 
                 moduleController.DnnPage = context.DnnPage;

DNN Platform/Library/UI/Modules/ModuleInstanceContext.cs

@@ -510,6 +510,16 @@ private void LoadActions(HttpRequest request)
             var actionable = this.moduleControl as IActionable;
             if (actionable != null)
             {
+                // Async module controls populate ModuleActions only after their async task executes.
+                // Leave this.actions as null so the Actions getter retries once results are available.
+                if (this.moduleControl is IAsyncModuleControl && actionable.ModuleActions == null)
+                {
+                    this.actions = null;
+
+                    // TODO: Should we throw instead to be able to identify code that tries to call it too early?
+                    return;
+                }
+
                 this.moduleSpecificActions = new ModuleAction(this.GetNextActionID(), Localization.GetString("ModuleSpecificActions.Action", Localization.GlobalResourceFile), string.Empty, string.Empty, string.Empty);
 
                 ModuleActionCollection moduleActions = actionable.ModuleActions;