You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_PROCESS.md
+4-4Lines changed: 4 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -22,6 +22,8 @@ The following items must all be true prior to a pull request being submitted to
22
22
## Code Review Process
23
23
Community review of submitted pull requests is encouraged, and all pull requests must be reviewed by at least **two (2)** designated approvers before the change can be approved. Once approved by two unique designated approvers, the change can be merged. An approver should NEVER merge their own change, even with two supporting approvals.
24
24
25
+
The DNN Platform project strives to review and comment on incoming pull requests in a timely fashion, however, it may be necessary at times to hold incoming pull requests for a period of time during releases or other administrative processes.
26
+
25
27
### Designated Approvers
26
28
At the current time the following community members are designated approvers.
27
29
@@ -31,8 +33,6 @@ At the current time the following community members are designated approvers.
31
33
* Peter Donker ([donker](https://github.com/donker)) - Community Developer Advisory Group Lead
32
34
* Daniel Valadas ([valadas](https://github.com/valadas))
33
35
* Matt Rutledge ([mtrutledge](https://github.com/mtrutledge))
* Erik van Ballegoij ([erikvb](https://github.com/erikvb))
36
36
37
37
Additionally, the following individuals from ESW/DNN Corp are approved reviewers.
38
38
@@ -56,8 +56,8 @@ Once a pull request has been reviewed by two designated approvers it may be merg
56
56
57
57
> This **_MUST NOT_** be done by the submitter of the Pull Request for ANY reason!
58
58
59
-
### Exception for Build Process Pull Requests
60
-
A special exception has been granted to reduce the number of Designed Approval reviews to 1 for all pull requests related to Build Support when incrementing versions in preparation of a release, or reconfiguration of the environment for the next version.
59
+
### Execption for Build Process Pull Requests
60
+
A special exception has been granted to reduce the number of Designed Approval reviews to 1 for all pull requests related to Build Support when incrementing versions in prepration of a release, adjustments of build processes, or reconfiguration of the environment for the next version.
61
61
62
62
Additionally a special exception has been granted to merge pull requests created by the Designated Approvers for the purposes of keeping release branches in sync when the pull request ONLY moves previously approved changes. Such as moving bug fixes from a minor release into the next major release, or otherwise.
Copy file name to clipboardExpand all lines: .github/VERSIONING_POLICY.md
+4-2Lines changed: 4 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,7 +1,7 @@
1
1
# DNN Platform Versioning and Deprecation Policies
2
2
The DNN Platform follows a semantic versioning process for releases, in a manner to better communicate expectations of releases and their potential impacts to users of the platform.
3
3
4
-
##Semantic Versioning
4
+
##Semantic Versioning
5
5
The DNN Community adopted the current semantic version policy in July of 2018. Releases before this date may follow different standards.
6
6
7
7
### Major Releases (Ex 10.0.0)
@@ -10,14 +10,16 @@ A major release is as the name implies, a release with major changes. These cha
10
10
Major releases are also the time that platform requirements might be changed, such as requiring a new edition of SQL Server or otherwise.
11
11
12
12
### Minor Releases (Ex 10.1, 10.2, 10.x)
13
-
A minor might contain smaller new features and enhancements, but will not introduce any breaking API changes, nor will it change the requirements of the hosting environment or platform to run the application.
13
+
A minor might contain smaller new features and enhancements, however, best efforts will be taken to minimize breaking changes.
14
14
15
15
### Revision Releases (Ex 10.1.1, 10.1.2, 10.1.x)
16
16
These releases are created primarily to contain hot-fix style improvements from prior releases. Any bugs or security issues identified, or missing UI/UX features from a Minor/Major release might be added to a revision release. Similar to a Minor release a Revision release will not contain any known breaking changes.
17
17
18
18
## API Deprecation Policy
19
19
The DNN Platform project is in a state of transition, continuing to modernize the API and work towards a transition to .NET Core. To this point, it will be necessary for the project to remove public API's. This will be done methodically, allowing developers to transition away from the older code with time to properly respond to change.
20
+
20
21
Any API method to be removed will be flagged as deprecated in a release, major, minor or revision, and will be identified to be removed by a specific version. This will be done using a C# annotation with a comment similar to the following "Deprecated in x.x.x. Scheduled for removal in vy.0.0, use ____ instead". The version number of "y" in this example must be 2 major versions ahead.
22
+
21
23
Therefore, an API marked as Deprecated in 9.2.1 can only be removed in version 11.0. Additionally, methods marked for removal in a version will GUARANTEED be removed in that revision.
22
24
> Example: [Obsolete("Deprecated in DotNetNuke 7.0. This function has been replaced by AddUserRole with additional params. Scheduled removal in v10.0.0.")]
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+3-2Lines changed: 3 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -28,7 +28,7 @@ If this is your first time working with Dnn:Platform. You will need to fork the
28
28
## Making Changes
29
29
30
30
* Create a topic branch from where you want to base your work.
31
-
* This is usually the 'development' branch.
31
+
* This is usually the 'development' branch.
32
32
* Release branches should only be targeted in special cases and with approval from the approver group.
33
33
* To quickly create a topic branch based on development; `git checkout -b my_contribution development`
34
34
* Make commits of logical units.
@@ -74,7 +74,8 @@ a ticket number.
74
74
The first line is a real-life imperative statement with '(doc)' in place of what would have been the ticket number in a non-documentation related commit. The body describes the nature of the new documentation or comments added.
75
75
````
76
76
77
-
## Submitting Changes
77
+
# Submitting & Process of Pull Requests
78
+
78
79
Once your change is completed you will want to follow the [Pull Request Process](https://github.com/dnnsoftware/Dnn.Platform/blob/development/.github/PULL_REQUEST_PROCESS.md) to submit your changes for review & inclusion in the next release.
*[DNN on Facebook](http://www.facebook.com/DNNsoftware)
40
35
*[DNN on Twitter](http://www.Twitter.com/DNN)
41
36
*[DNN Store](http://store.dnnsoftware.com/)
42
37
43
-
## How to Contribute
38
+
## Contributing to DNN Platform
39
+
40
+
We encourage contributions of all forms, including code changes, testing, bug reports or otherwise. The following resources outline detailed contribution procedures.
44
41
45
-
We encourage everyone to contribute.
46
-
All the details on contributing with Git and on our working methods can be found on the [Contribute Page](CONTRIBUTING.md)
In addition, since DNN is part of the .NET Foundation, we require our contributors to abide by their [Code of Conduct](https://www.dotnetfoundation.org/code-of-conduct) rules and requirements also.
49
48
@@ -54,4 +53,5 @@ This project is supported by the [.NET Foundation](https://dotnetfoundation.org)
54
53
## NDepend
55
54
56
55
We monitor code quality of the DNN Platform using [NDepend](https://www.ndepend.com).
0 commit comments