Finish Dependency Injection Support for PortalController

[SkyeHoefling]

Description of problem

Since support has been stabilized for Dependency Injection the goal is to add better support across the different static APIs. The PortalController current supports Dependency Injection via IPortalController however many APIs are missing because they are static APIs.

For example: If you need to decrypt portal settings you would use the following API

PortalController.GetEncryptedString(string settingName, int portalID, string passPhrase);

There is no instance level API method that supports this, which makes it difficult to use with Dependency Injection.

Description of solution

Create a copy of every static API in the PortalController for the IPortalController. Then mark the existing static API obsolete while using the new instance version.

If we were to use the example above with GetEncryptedString. Move the declaration to the IPortalController.

public interface IPortalController
{
    string GetEncryptedString(string settingName, int portalID, string passPhrase);    

    // omitted code

Then update the PortalController code to have both

public class PortalController
{
    [Obsolete("Deprecated in DNN 9.7.0. Use the 'IPortalController.GetEncryptedString' instnace method. Scheduled removal in v11.0.0.")]
    public static string GetEncryptedString(string settingName, int portalID, string passPhrase) =>
        GetEncryptedString(settingName, portalID, passPhrase);

    string IPortalController.GetEncryptedString(string settingName, int portalID, string passPhrase)
    {
        // omitted code
    }
}

Description of alternatives considered

N/A

Screenshots

N/A

Additional context

This change will effect the entire platform

Affected browser

N/A

[stale]

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

[stale]

This issue has been closed automatically due to inactivity (as mentioned 14 days ago). Feel free to re-open the issue if you believe it is still relevant.

[SkyeHoefling]

This was never finished, I think it should be reopened and pinned. cc: @mitchelsellers

[valadas]

Reopened and pinned.