FIX: Ckeditor padding + heading sizes#7368
Draft
Timo-Breumelhof wants to merge 2 commits into
Draft
Conversation
valadas
approved these changes
Jul 10, 2026
valadas
left a comment
Contributor
There was a problem hiding this comment.
This technically affects more than the problem in question and technically is a bit of a change for all usages of the ui/ux pattern. However I do believe it is the right thing to do as those headers were incorrectly huge everywhere. So my vote goes to just go ahead with this change.
Contributor
|
@Timo-Breumelhof this is marked as draft, is that on purpose because you are still working on it w you want to mark this ready for review? |
Contributor
Author
|
@valadas yes, I still need to check something but ran out of time, I'll finish this one next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 Commits.
A. Very simple add some padding to the CkEditor screen
B. For the heading sizes, ended up being a bit more complex.
Summary
About the Heading size issue.
I noticed this:
A difference in heading sizes.
dnnFormSectionHead can contain a link or a span
The second one contains a span the others a link.
Span size:
Dnn.Platform/DNN Platform/Dnn.ClientSide/src/styles/default-css/10.0.0/ui/_forms.scss
Line 249 in 1e3b3c8
Anchor size:
Dnn.Platform/DNN Platform/Dnn.ClientSide/src/styles/default-css/10.0.0/default.scss
Line 20 in 1e3b3c8
This is why they are different.
If you look at the interface, the heading a really large and IMO the size of the span is actually better than the ones containing a link. In edit users you get this:
Which looks weird IMO
So I moved what was in forms.scss into default.scss (not the best place but at least in one place)
And made them both the same size in rem.
There's a lot more one could changes here, but for now this at least fixes the issue of the header sizes.
FYI,
Manage users after this change:
Ckeditor manager
fixes #7367