feat(menu): fetch thinking levels from Pi server, drop compat.reasoningEffortMap fallback#251
Open
ArthurHeymans wants to merge 1 commit into
Open
feat(menu): fetch thinking levels from Pi server, drop compat.reasoningEffortMap fallback#251ArthurHeymans wants to merge 1 commit into
ArthurHeymans wants to merge 1 commit into
Conversation
…ngEffortMap fallback Replace the hardcoded `pi-coding-agent--thinking-levels` constant with dynamic fetching via the RPC command `get_available_thinking_levels`. - `pi-coding-agent--thinking-level-effective-value`: translate a pi thinking level to its provider-specific value using `thinkingLevelMap` - `pi-coding-agent--filter-thinking-level-aliases`: deduplicate levels that map to the same provider value; omit unsupported (`null`) levels - `pi-coding-agent--get-available-thinking-levels`: RPC fetch + filtering - `pi-coding-agent--refresh-thinking-level-state`: refresh UI state after `set_thinking_level` so server-side clamping is reflected Also: - Remove the dead `compat.reasoningEffortMap` fallback — that property was replaced by `thinkingLevelMap` in pi v0.72.0 and is never sent by pi >= 0.81.0 (the new minimum) - Update the alias-filtering test to use `thinkingLevelMap` and cover `"max"` aliasing - Bump minimum pi version from 0.79.1 → 0.81.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hardcoded
pi-coding-agent--thinking-levelsconstant withdynamic fetching via the RPC command
get_available_thinking_levels.pi-coding-agent--thinking-level-effective-value: translate a pithinking level to its provider-specific value using
thinkingLevelMappi-coding-agent--filter-thinking-level-aliases: deduplicate levelsthat map to the same provider value; omit unsupported (
null) levelspi-coding-agent--get-available-thinking-levels: RPC fetch + filteringpi-coding-agent--refresh-thinking-level-state: refresh UI state afterset_thinking_levelso server-side clamping is reflectedAlso:
compat.reasoningEffortMapfallback — that propertywas replaced by
thinkingLevelMapin pi v0.72.0 and is never sent bypi >= 0.81.0 (the new minimum)
thinkingLevelMapand cover"max"aliasing