Remove deprecated Certificate contact_id field#328
Merged
Conversation
The `contact_id` field in the Certificate schema was deprecated on 2022-05-17 and is no longer required for certificate operations. Remove it from the `Certificate` defstruct. This is a breaking change.
3 tasks
Signed-off-by: Simone Carletti <5387+weppos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the deprecated
contact_idfield from theCertificatedefstruct. The field was deprecated on 2022-05-17 and is no longer required for certificate operations.This is a breaking change.
Tracking PR: dnsimple/dnsimple-developer#987
Test plan
contact_id