From 825fe7954a02df6531f8666df2e4a1ef5b45db5e Mon Sep 17 00:00:00 2001 From: Simone Carletti <5387+weppos@users.noreply.github.com> Date: Thu, 16 Apr 2026 14:24:48 +0200 Subject: [PATCH] Remove deprecated Certificate contact_id field The `contact_id` field in the Certificate schema was deprecated on 2022-05-17 and is no longer required for certificate operations. Remove it from the `Certificate` defstruct. This is a breaking change. --- CHANGELOG.md | 6 ++++++ lib/dnsimple/certificate.ex | 3 +-- test/dnsimple/certificates_test.exs | 1 - 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3d8df515..45079b36 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,12 @@ This project uses [Semantic Versioning 2.0.0](http://semver.org/), the format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). +## main + +### Removed + +- **BREAKING**: Removed the deprecated `contact_id` field from the `Certificate` struct. The field was deprecated on 2022-05-17 and is no longer required for certificate operations. + ## 8.3.0 - 2026-04-15 ### Added diff --git a/lib/dnsimple/certificate.ex b/lib/dnsimple/certificate.ex index 83e52e65..13f1c680 100644 --- a/lib/dnsimple/certificate.ex +++ b/lib/dnsimple/certificate.ex @@ -17,7 +17,6 @@ defmodule Dnsimple.Certificate do @type t :: %__MODULE__{ id: integer, domain_id: integer, - contact_id: integer, common_name: String.t, alternate_names: List.t, years: integer, @@ -35,7 +34,7 @@ defmodule Dnsimple.Certificate do chain: String.t, } - defstruct ~w(id domain_id contact_id + defstruct ~w(id domain_id common_name alternate_names years csr state authority_identifier auto_renew created_at updated_at expires_at server root chain private_key)a diff --git a/test/dnsimple/certificates_test.exs b/test/dnsimple/certificates_test.exs index fb5d5c9e..5dfa8540 100644 --- a/test/dnsimple/certificates_test.exs +++ b/test/dnsimple/certificates_test.exs @@ -62,7 +62,6 @@ defmodule Dnsimple.CertificatesTest do assert data.__struct__ == Dnsimple.Certificate assert data.id == 101967 assert data.domain_id == 289333 - assert data.contact_id == 2511 assert data.common_name == "www.bingo.pizza" assert data.alternate_names == [] assert data.auto_renew == false