Skip to content

Commit 2621018

Browse files
authored
Remove deprecated Certificate contact_id field (#285)
The `contact_id` field in the Certificate schema was deprecated on 2022-05-17 and is no longer required for certificate operations. Remove it from the `Certificate` type. This is a breaking change. References dnsimple/dnsimple-developer#987
1 parent f58efde commit 2621018

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
This project uses [Semantic Versioning 2.0.0](http://semver.org/), the format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
44

5+
## main
6+
7+
### Removed
8+
9+
- **BREAKING**: Removed the deprecated `contact_id` field from the `Certificate` type. The field was deprecated on 2022-05-17 and is no longer required for certificate operations.
10+
511
## 12.3.0 - 2026-04-16
612

713
### Added

lib/types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ export type Push = {
115115
export type Certificate = {
116116
id: number;
117117
domain_id: number;
118-
contact_id: number;
119118
name: string;
120119
common_name: string;
121120
years: number;

test/certificates.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,6 @@ describe("certificates", () => {
135135
const certificate = response.data;
136136
expect(certificate.id).toBe(101967);
137137
expect(certificate.domain_id).toBe(289333);
138-
expect(certificate.contact_id).toBe(2511);
139138
expect(certificate.common_name).toBe("www.bingo.pizza");
140139
expect(certificate.alternate_names).toEqual([]);
141140
expect(certificate.state).toBe("issued");

0 commit comments

Comments
 (0)