Skip to content

fix(types): update suppressed_at and last_transferred_at to be nullable#296

Open
Rohan170603 wants to merge 1 commit into
dnsimple:mainfrom
Rohan170603:fix/nullable-datetime-types
Open

fix(types): update suppressed_at and last_transferred_at to be nullable#296
Rohan170603 wants to merge 1 commit into
dnsimple:mainfrom
Rohan170603:fix/nullable-datetime-types

Conversation

@Rohan170603

Copy link
Copy Markdown

Description

This PR fixes type-mismatch bugs between the TypeScript definitions and the SDK's internal API mock fixtures.

Fixes

  • Webhook.suppressed_at: Updated from string to NullableDateTime. Active webhooks return null when not suppressed, which caused a type mismatch against the strict string definition.
  • Zone.last_transferred_at: Updated from string to NullableDateTime. Profiles for domains or zones that have not undergone an external transfer return null.

All test suites pass cleanly with zero regressions.

@Rohan170603
Rohan170603 force-pushed the fix/nullable-datetime-types branch from d9162ff to c98ebab Compare June 17, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant