Skip to content

chore: sync listCharges fixture with certificate-purchase entry #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggalmazor merged 2 commits into from
Apr 18, 2026
Merged

chore: sync listCharges fixture with certificate-purchase entry #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6c8340
chore: sync listCharges fixture with certificate-purchase entry
ggalmazor Apr 17, 2026
667c576
chore: add CHANGELOG entry for listCharges fixture sync
ggalmazor Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ This project uses [Semantic Versioning 2.0.0](http://semver.org/), the format is

## main

### Changed

- Updated the `listCharges` test fixture to include a certificate purchase entry demonstrating that `productReference` is a string even when it represents a numeric ID. (#166)

### Removed

- **BREAKING**: Removed the deprecated `contactId` field from the `Certificate` struct. The field was deprecated on 2022-05-17 and is no longer required for certificate operations.
Expand Down
9 changes: 7 additions & 2 deletions tests/Dnsimple/Service/BillingTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public function testListCharges()
self::assertEquals(200, $response->getStatusCode());

$data = $response->getData();
self::assertCount(3, $data);
self::assertCount(4, $data);

$charge = $data[0];
self::assertInstanceOf(Charge::class, $charge);
Expand All @@ -40,6 +40,11 @@ public function testListCharges()
self::assertInstanceOf(BigDecimal::class, $item->amount);
self::assertEquals(BigDecimal::of("14.50"), $item->amount);
self::assertEquals("Register bubble-registered.com", $item->description);

$certCharge = $data[3];
self::assertEquals("5-2", $certCharge->reference);
self::assertEquals("certificate-purchase", $certCharge->items[0]->productType);
self::assertSame("42", $certCharge->items[0]->productReference);
}

public function testListChargesSupportsFilters()
Expand Down Expand Up @@ -67,7 +72,7 @@ public function testListChargesHasPaginationObject()

self::assertEquals(1, $pagination->currentPage);
self::assertEquals(30, $pagination->perPage);
self::assertEquals(3, $pagination->totalEntries);
self::assertEquals(4, $pagination->totalEntries);
self::assertEquals(1, $pagination->totalPages);
}

Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/v2/api/listCharges/success.http
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ cache-control: no-store, must-revalidate, private, max-age=0
x-request-id: a57a87c8-626a-4361-9fb8-b55ca9be8e5d
x-runtime: 0.060526

{"data":[{"invoiced_at":"2023-08-17T05:53:36Z","total_amount":"14.50","balance_amount":"0.00","reference":"1-2","state":"collected","items":[{"description":"Register bubble-registered.com","amount":"14.50","product_id":1,"product_type":"domain-registration","product_reference":"bubble-registered.com"}]},{"invoiced_at":"2023-08-17T05:57:53Z","total_amount":"14.50","balance_amount":"0.00","reference":"2-2","state":"refunded","items":[{"description":"Register example.com","amount":"14.50","product_id":2,"product_type":"domain-registration","product_reference":"example.com"}]},{"invoiced_at":"2023-10-24T07:49:05Z","total_amount":"1099999.99","balance_amount":"0.00","reference":"4-2","state":"collected","items":[{"description":"Test Line Item 1","amount":"99999.99","product_id":null,"product_type":"manual","product_reference":null},{"description":"Test Line Item 2","amount":"1000000.00","product_id":null,"product_type":"manual","product_reference":null}]}],"pagination":{"current_page":1,"per_page":30,"total_entries":3,"total_pages":1}}
{"data":[{"invoiced_at":"2023-08-17T05:53:36Z","total_amount":"14.50","balance_amount":"0.00","reference":"1-2","state":"collected","items":[{"description":"Register bubble-registered.com","amount":"14.50","product_id":1,"product_type":"domain-registration","product_reference":"bubble-registered.com"}]},{"invoiced_at":"2023-08-17T05:57:53Z","total_amount":"14.50","balance_amount":"0.00","reference":"2-2","state":"refunded","items":[{"description":"Register example.com","amount":"14.50","product_id":2,"product_type":"domain-registration","product_reference":"example.com"}]},{"invoiced_at":"2023-10-24T07:49:05Z","total_amount":"1099999.99","balance_amount":"0.00","reference":"4-2","state":"collected","items":[{"description":"Test Line Item 1","amount":"99999.99","product_id":null,"product_type":"manual","product_reference":null},{"description":"Test Line Item 2","amount":"1000000.00","product_id":null,"product_type":"manual","product_reference":null}]},{"invoiced_at":"2023-10-24T09:00:00Z","total_amount":"20.00","balance_amount":"0.00","reference":"5-2","state":"collected","items":[{"description":"Purchase Certificate www.bubble-registered.com","amount":"20.00","product_id":42,"product_type":"certificate-purchase","product_reference":"42"}]}],"pagination":{"current_page":1,"per_page":30,"total_entries":4,"total_pages":1}}