fix: address PR #40 review comments

- fix(engine): propagate recreate=true through pendingOverflow queue
  When a recreate request is queued while indexing, tryStartPendingIndex
  now correctly passes recreate=true to the follow-up job.

- fix(index_status): Windows-safe atomic rename fallback
  os.Rename fails on Windows when dest exists; now falls back to
  remove-then-rename.

- fix(docs/treesitter): avoid materializing huge strings for massive
  leaf nodes — slice source bytes directly when nodeLen > 8192.

- cleanup(tests): remove empty t.Cleanup block in fallback search test.

Author: razvan

internal/service/engine/engine.go

@@ -762,8 +762,8 @@ func (e *Engine) popPendingIndex(workspaceID string) (files []string, overflow b
 func (e *Engine) tryStartPendingIndex(root, workspaceID string) {
 	files, overflow := e.popPendingIndex(workspaceID)
 	if overflow {
-		logger.Instance.Info("[IDX] ♻️ Pending changes exceeded limit for ws=%s — triggering full scan", filepath.Base(root))
-		e.StartIndexingAsync(root, workspaceID, nil, false)
+		logger.Instance.Info("[IDX] ♻️ Pending changes exceeded limit for ws=%s — triggering full re-index", filepath.Base(root))
+		e.StartIndexingAsync(root, workspaceID, nil, true)
 		return
 	}
 	if len(files) == 0 {

internal/service/engine/engine_fallback_search_test.go

@@ -94,9 +94,7 @@ func ValidateEmail(email string) bool {
 	eng := NewEngine(idxSvc, searchSvc, "", &config.Config{})
 	eng.SetResolver(resolver.New(resolver.Dependencies{Detector: &mockDirDetector{root: root}}))
 
-	t.Cleanup(func() {
 
-	})
 
 	return root, eng
 }

pkg/indexer/index_status.go

@@ -65,8 +65,12 @@ func SaveIndexStatus(workspaceRoot string, status *IndexStatus) {
 	}
 	path := filepath.Join(dir, indexStatusFile)
 	if err := os.Rename(tmpName, path); err != nil {
-		os.Remove(tmpName)
-		logger.Instance.Warn("index_status: rename failed for %s: %v", path, err)
+		// Windows-safe fallback: os.Rename fails when dest exists on Windows.
+		_ = os.Remove(path)
+		if err2 := os.Rename(tmpName, path); err2 != nil {
+			os.Remove(tmpName)
+			logger.Instance.Warn("index_status: rename failed for %s: %v", path, err2)
+		}
 	}
 }
 

pkg/parser/docs/treesitter.go

@@ -47,19 +47,26 @@ func (p *TreeSitterParser) Parse(source []byte, filePath string, ext string) ([]
 
 		// A leaf or a reasonably sized chunk (~1500 chars) -> make it a valid symbol chunk
 		if node.ChildCount() == 0 || nodeLen <= 1500 {
-			text := strings.TrimSpace(node.Text(source))
+			// Prevent massive leaf nodes (e.g. 50MB SQL INSERT values) from
+			// allocating the full string — slice the underlying bytes directly.
+			var text string
+			if nodeLen > 8192 {
+				end := int(node.StartByte()) + 8192
+				if end > len(source) {
+					end = len(source)
+				}
+				text = strings.TrimSpace(string(source[node.StartByte():end])) + "\n...[TRUNCATED]"
+			} else {
+				text = strings.TrimSpace(node.Text(source))
+			}
+
 			if len(text) < 10 {
 				for i := 0; i < node.ChildCount(); i++ {
 					walk(node.Child(i), parentSig)
 				}
 				return
 			}
 
-			// Prevent massive leaf nodes (e.g. 50MB SQL INSERT values) from crashing Ollama
-			if len(text) > 8192 {
-				text = text[:8192] + "\n...[TRUNCATED]"
-			}
-
 			startLine := int(node.StartPoint().Row) + 1
 			endLine := int(node.EndPoint().Row) + 1