Skip to content

Commit 5e617e5

Browse files
author
razvan
committed
fix: skip empty model names in healthcheck, check only embed model in evaluate
- healthcheck: skip empty strings in requiredModels to avoid false negatives - evaluate: check only OllamaEmbed (not OllamaModel) since RagCode only uses embeddings
1 parent 0270ad6 commit 5e617e5

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

internal/healthcheck/healthcheck.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,9 @@ func CheckOllamaWithModels(baseURL string, requiredModels []string) CheckResult
242242

243243
var missing []string
244244
for _, requiredModel := range requiredModels {
245+
if strings.TrimSpace(requiredModel) == "" {
246+
continue
247+
}
245248
reqBase, reqTag := normalizeModelName(requiredModel)
246249
found := false
247250

internal/service/tools/evaluate_ragcode.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ func (t *EvaluateRagCodeTool) Execute(ctx context.Context, args map[string]inter
7474

7575
var healthStatus []string
7676
if t.cfg != nil {
77-
models := []string{t.cfg.LLM.OllamaModel, t.cfg.LLM.OllamaEmbed}
77+
models := []string{t.cfg.LLM.OllamaEmbed}
7878
health := healthcheck.CheckAllWithModels(t.cfg.LLM.OllamaBaseURL, t.cfg.Storage.VectorDB.URL, models)
7979
for _, h := range health {
8080
statusSymbol := "✅"

0 commit comments

Comments
 (0)