fix: address lint issues and tracking bin

Author: doITmagic

cmd/install/main.go

@@ -335,7 +335,9 @@ func setupServices() {
 		}
 
 		// Ensure local models dir exists
-		os.MkdirAll(localModels, 0755)
+		if err := os.MkdirAll(localModels, 0755); err != nil {
+			fail(fmt.Sprintf("Could not create Ollama models dir: %v", err))
+		}
 
 		args := []string{
 			"-p", "11434:11434",
@@ -367,7 +369,12 @@ func startDockerContainer(name, image string, args []string, env []string) {
 	}
 
 	// Remove if exists but stopped
-	exec.Command("docker", "rm", name).Run()
+	if err := exec.Command("docker", "rm", name).Run(); err != nil {
+		// ignore if container didn't exist, but log other errors
+		if exitErr, ok := err.(*exec.ExitError); !ok || exitErr.ExitCode() != 1 {
+			warn(fmt.Sprintf("Failed to remove existing container %s: %v", name, err))
+		}
+	}
 
 	// Run
 	runArgs := []string{"run", "-d", "--name", name, "--restart", "unless-stopped"}
@@ -663,7 +670,9 @@ func updateMCPConfig(ideKey, displayName, path, binPath string) {
 
 	// Read existing
 	if data, err := os.ReadFile(path); err == nil {
-		json.Unmarshal(data, &config)
+		if err := json.Unmarshal(data, &config); err != nil {
+			warn(fmt.Sprintf("Failed to parse existing MCP config %s: %v", path, err))
+		}
 	}
 
 	collectionKey := "mcpServers"

cmd/rag-code-mcp/main.go

@@ -11,7 +11,6 @@ import (
 	"os"
 	"os/signal"
 	"path/filepath"
-	"runtime"
 	"strings"
 	"syscall"
 	"time"
@@ -79,25 +78,6 @@ func (l *simpleLogger) Warn(format string, args ...interface{}) {
 
 var logger = &simpleLogger{}
 
-func getAppDataDir() (string, error) {
-	home, err := os.UserHomeDir()
-	if err != nil {
-		return "", err
-	}
-
-	if runtime.GOOS == "windows" {
-		return filepath.Join(home, "AppData", "Local", "ragcode"), nil
-	} else if runtime.GOOS == "darwin" {
-		return filepath.Join(home, "Library", "Application Support", "ragcode"), nil
-	}
-
-	// Linux / Unix standard (XDG state home or fallback to local/state)
-	if xdgState := os.Getenv("XDG_STATE_HOME"); xdgState != "" {
-		return filepath.Join(xdgState, "ragcode"), nil
-	}
-	return filepath.Join(home, ".local", "state", "ragcode"), nil
-}
-
 func resolveLogPath(path string) (string, error) {
 	if path == "" {
 		return "", nil

internal/workspace/manager.go

@@ -158,16 +158,6 @@ func (s *workspaceScan) fingerprint(language string) string {
 	return fmt.Sprintf("%x", h.Sum64())
 }
 
-// Helper to check if a slice contains a string
-func contains(slice []string, item string) bool {
-	for _, s := range slice {
-		if s == item {
-			return true
-		}
-	}
-	return false
-}
-
 func (m *Manager) fingerprintKey(info *Info, language string) string {
 	return info.ID + "-" + strings.ToLower(language)
 }

internal/workspace/watcher.go

@@ -56,7 +56,10 @@ func (fw *FileWatcher) Start() {
 			if strings.HasPrefix(base, ".") && base != "." && base != ".git" {
 				return filepath.SkipDir
 			}
-			return fw.watcher.Add(path)
+			if err := fw.watcher.Add(path); err != nil {
+				log.Printf("[WARN] Unable to watch %s: %v", path, err)
+			}
+			return nil
 		}
 		return nil
 	})
@@ -90,7 +93,9 @@ func (fw *FileWatcher) watchLoop() {
 					// Skip if ignored
 					base := filepath.Base(event.Name)
 					if _, skip := defaultSkipDirs[base]; !skip && !strings.HasPrefix(base, ".") {
-						fw.watcher.Add(event.Name)
+						if err := fw.watcher.Add(event.Name); err != nil {
+							log.Printf("[WARN] Unable to watch new dir %s: %v", event.Name, err)
+						}
 					}
 				}
 			}