replace direct enum indexing with fromNative method for safer result handling

Author: doblon8

src/main/java/io/github/doblon8/openpnp/capture/CaptureContext.java

@@ -16,7 +16,7 @@ public CaptureContext() {
     @Override
     public void close() throws CaptureException{
         int result = Cap_releaseContext(segment);
-        CaptureResult captureResult = CaptureResult.values()[result];
+        CaptureResult captureResult = CaptureResult.fromNative(result);
         if (captureResult != CaptureResult.OK) {
             throw new CaptureException("Error releasing capture context: " + result);
         }
@@ -25,4 +25,4 @@ public void close() throws CaptureException{
     MemorySegment getSegment() {
         return segment;
     }
-}
+}

src/main/java/io/github/doblon8/openpnp/capture/CaptureDevice.java

@@ -104,7 +104,7 @@ private CaptureFormatInfo getFormatInfo(int deviceId, int formatId) throws Captu
         try (Arena arena = Arena.ofConfined()) {
             MemorySegment formatInfoSegment = CapFormatInfo.allocate(arena);
             int result = Cap_getFormatInfo(context.getSegment(), deviceId, formatId, formatInfoSegment);
-            CaptureResult captureResult = CaptureResult.values()[result];
+            CaptureResult captureResult = CaptureResult.fromNative(result);
             if (captureResult == CaptureResult.OK) {
                 return new CaptureFormatInfo(formatInfoSegment);
             }

src/main/java/io/github/doblon8/openpnp/capture/CaptureResult.java

@@ -5,5 +5,14 @@ public enum CaptureResult {
     ERROR,
     DEVICE_NOT_FOUND,
     FORMAT_NOT_SUPPORTED,
-    PROPERTY_NOT_SUPPORTED,
+    PROPERTY_NOT_SUPPORTED;
+
+    private static final CaptureResult[] VALUES = CaptureResult.values();
+
+    public static CaptureResult fromNative(int value) {
+        if (value < 0 || value >= VALUES.length) {
+            throw new CaptureException("Unknown capture result code: " + value);
+        }
+        return VALUES[value];
+    }
 }

src/main/java/io/github/doblon8/openpnp/capture/CaptureStream.java

@@ -33,7 +33,7 @@ public BufferedImage capture() {
             MemorySegment bufferPointer = arena.allocate(ValueLayout.JAVA_BYTE, numBytes);
 
             int result = Cap_captureFrame(context.getSegment(), id, bufferPointer, numBytes);
-            CaptureResult captureResult = CaptureResult.values()[result];
+            CaptureResult captureResult = CaptureResult.fromNative(result);
             if (captureResult != CaptureResult.OK) {
                 throw new CaptureException("Error capturing frame: " + result);
             }
@@ -87,7 +87,7 @@ public PropertyLimits getPropertyLimits(CaptureProperty property) {
             MemorySegment defaultValuePointer = arena.allocate(ValueLayout.JAVA_INT);
 
             int result = Cap_getPropertyLimits(context.getSegment(), id, property.value(), minPointer, maxPointer, defaultValuePointer);
-            CaptureResult captureResult = CaptureResult.values()[result];
+            CaptureResult captureResult = CaptureResult.fromNative(result);
             return switch (captureResult) {
                 case OK -> new PropertyLimits(
                         minPointer.get(ValueLayout.JAVA_INT, 0),
@@ -112,7 +112,7 @@ public int getProperty(CaptureProperty property) {
         try (Arena arena = Arena.ofConfined()) {
             MemorySegment valuePointer = arena.allocate(ValueLayout.JAVA_INT);
             int result = Cap_getProperty(context.getSegment(), id, property.value(), valuePointer);
-            CaptureResult captureResult = CaptureResult.values()[result];
+            CaptureResult captureResult = CaptureResult.fromNative(result);
             return switch (captureResult) {
                 case OK -> valuePointer.get(ValueLayout.JAVA_INT, 0);
                 case PROPERTY_NOT_SUPPORTED -> throw new CaptureException("Property " + property + " is not supported by this stream.");
@@ -130,7 +130,7 @@ public int getProperty(CaptureProperty property) {
      */
     public void setProperty(CaptureProperty property, int value) {
         int result =  Cap_setProperty(context.getSegment(), id, property.value(), value);
-        CaptureResult captureResult = CaptureResult.values()[result];
+        CaptureResult captureResult = CaptureResult.fromNative(result);
         switch (captureResult) {
             case OK -> {}
             case PROPERTY_NOT_SUPPORTED -> throw new CaptureException("Property " + property + " is not supported by this stream.");
@@ -149,7 +149,7 @@ public boolean getAutoProperty(CaptureProperty property) {
         try (Arena arena = Arena.ofConfined()) {
             MemorySegment valuePointer = arena.allocate(ValueLayout.JAVA_INT);
             int result = Cap_getAutoProperty(context.getSegment(), id, property.value(), valuePointer);
-            CaptureResult captureResult = CaptureResult.values()[result];
+            CaptureResult captureResult = CaptureResult.fromNative(result);
             return switch (captureResult) {
                 case OK -> valuePointer.get(ValueLayout.JAVA_INT, 0) == 1;
                 case PROPERTY_NOT_SUPPORTED -> throw new CaptureException("Property " + property + " is not supported by this stream.");
@@ -167,7 +167,7 @@ public boolean getAutoProperty(CaptureProperty property) {
      */
     public void setAutoProperty(CaptureProperty property, boolean enable) {
             int result = Cap_setAutoProperty(context.getSegment(), id, property.value(), enable ? 1 : 0);
-            CaptureResult captureResult = CaptureResult.values()[result];
+            CaptureResult captureResult = CaptureResult.fromNative(result);
             switch (captureResult) {
                 case OK -> {}
                 case PROPERTY_NOT_SUPPORTED -> throw new CaptureException("Property " + property + " is not supported by this stream.");
@@ -193,7 +193,7 @@ public boolean isOpen() {
     @Override
     public void close() {
         int result = Cap_closeStream(context.getSegment(), id);
-        CaptureResult captureResult = CaptureResult.values()[result];
+        CaptureResult captureResult = CaptureResult.fromNative(result);
         if (captureResult != CaptureResult.OK) {
             throw new CaptureException("Error closing capture stream: " + result);
         }

src/main/java/io/github/doblon8/openpnp/capture/LogLevel.java

@@ -9,5 +9,14 @@ public enum LogLevel {
     NOTICE,
     INFO,
     DEBUG,
-    VERBOSE,
+    VERBOSE;
+
+    private static final LogLevel[] VALUES = values();
+
+    public static LogLevel fromNative(int value) {
+        if (value < 0 || value >= VALUES.length) {
+            throw new IllegalArgumentException("Unknown log level: " + value);
+        }
+        return VALUES[value];
+    }
 }

src/main/java/io/github/doblon8/openpnp/capture/OpenPnpCapture.java

@@ -59,7 +59,7 @@ public static void setLogLevel(LogLevel level) {
      */
     public static void installCustomLogFunction(BiConsumer<LogLevel, String> logFunction) {
         MemorySegment functionPointer = CapCustomLogFunc.allocate((level, stringPointer) ->
-                logFunction.accept(LogLevel.values()[level], stringPointer.getString(0)), arena);
+                logFunction.accept(LogLevel.fromNative(level), stringPointer.getString(0)), arena);
         Cap_installCustomLogFunction(functionPointer);
     }