Skip to content

Commit 83ce93a

Browse files
authored
Ensure initialization completed (#41)
* Added update mode * Fix reconnect issue #34 * Space between data in one area increased to 128 * Version update * Startup delay to ensure binding initialization completed
1 parent 9604f33 commit 83ce93a

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

org.openhab.binding.simatic/src/main/java/org/openhab/binding/simatic/internal/handler/simaticBridgeHandler.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
import java.nio.charset.Charset;
1616
import java.util.ArrayList;
17+
import java.util.concurrent.TimeUnit;
1718

1819
import org.eclipse.jdt.annotation.NonNull;
1920
import org.eclipse.jdt.annotation.NonNullByDefault;
@@ -49,7 +50,6 @@
4950
*/
5051
@NonNullByDefault
5152
public class SimaticBridgeHandler extends BaseBridgeHandler {
52-
5353
private final Logger logger = LoggerFactory.getLogger(SimaticBridgeHandler.class);
5454

5555
private @Nullable SimaticBridgeConfiguration config;
@@ -60,6 +60,8 @@ public class SimaticBridgeHandler extends BaseBridgeHandler {
6060
private @Nullable ChannelUID chVersion, chPduSize, chAreasCount, chAreas, chTagCount, chRequests, chBytes;
6161

6262
private int channelCount = 0;
63+
/** Initial scheduler delay */
64+
private static final long INIT_SECONDS = 5;
6365

6466
/**
6567
* Constructor
@@ -192,11 +194,11 @@ public void initialize() {
192194
updateStatus(ThingStatus.UNKNOWN);
193195

194196
// background initialization
195-
scheduler.execute(() -> {
197+
scheduler.schedule(() -> {
196198
if (!connection.open()) {
197199
updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR);
198200
}
199-
});
201+
}, INIT_SECONDS, TimeUnit.SECONDS);
200202
}
201203

202204
@Override

org.openhab.binding.simatic/src/main/java/org/openhab/binding/simatic/internal/simaticBindingConstants.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
@NonNullByDefault
2626
public class SimaticBindingConstants {
2727

28-
public static final String VERSION = "3.2.0";
28+
public static final String VERSION = "3.2.1";
2929

3030
private static final String BINDING_ID = "simatic";
3131

0 commit comments

Comments
 (0)