Skip to content

Commit 30b67a1

Browse files
committed
chore: Fix sonarqube issues
1 parent 1ba8be9 commit 30b67a1

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

src/test/java/dev/dochia/cli/core/report/BucketsCalculatorTest.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,9 @@ void testBucketsByReason() {
127127
var t2 = summary("2", 500, "reason2", "body2", true, false, "/b");
128128
var t3 = summary("3", 400, "reason1", "body3", true, false, "/c");
129129
List<Map<String, Object>> result = BucketsCalculator.createBuckets(List.of(t1, t2, t3));
130-
assertThat(result).hasSize(2);
131-
assertThat(result).anySatisfy(map -> assertThat(map.get("resultReason")).isEqualTo("reason1"));
132-
assertThat(result).anySatisfy(map -> assertThat(map.get("resultReason")).isEqualTo("reason2"));
130+
assertThat(result).hasSize(2)
131+
.anySatisfy(map -> assertThat(map).containsEntry("resultReason", "reason1"))
132+
.anySatisfy(map -> assertThat(map).containsEntry("resultReason", "reason2"));
133133
}
134134

135135
@Test
@@ -139,30 +139,30 @@ void testBucketsByEmptyResponseBody() {
139139
var t3 = summary("3", 404, "reason", " ", true, false, "/c");
140140
List<Map<String, Object>> result = BucketsCalculator.createBuckets(List.of(t1, t2, t3));
141141
assertThat(result).hasSize(1);
142-
var buckets = (List<?>) result.get(0).get("buckets");
142+
var buckets = (List<?>) result.getFirst().get("buckets");
143143
assertThat(buckets).hasSize(1);
144-
var bucket = (Map<?, ?>) buckets.get(0);
145-
assertThat(bucket.get("errorMessage")).isEqualTo("<empty response body>");
144+
Map<String, Object> bucket = (Map<String, Object>) buckets.getFirst();
145+
assertThat(bucket).containsEntry("errorMessage", "<empty response body>");
146146
}
147147

148148
@Test
149149
void testBucketsByExactResponseBody() {
150150
var t1 = summary("1", 404, "reason", "body", true, false, "/a");
151151
var t2 = summary("2", 404, "reason", "body", true, false, "/b");
152152
List<Map<String, Object>> result = BucketsCalculator.createBuckets(List.of(t1, t2));
153-
var buckets = (List<?>) result.get(0).get("buckets");
153+
var buckets = (List<?>) result.getFirst().get("buckets");
154154
assertThat(buckets).hasSize(1);
155-
var bucket = (Map<?, ?>) buckets.get(0);
156-
assertThat(bucket.get("errorMessage")).isEqualTo("body");
157-
var paths = (List<?>) bucket.get("paths");
155+
Map<String, Object> bucket = (Map<String, Object>) buckets.getFirst();
156+
assertThat(bucket).containsEntry("errorMessage", "body");
157+
List<String> paths = (List<String>) bucket.get("paths");
158158
assertThat(paths).hasSize(2);
159159
}
160160

161161
@ParameterizedTest
162162
@MethodSource("bucketsSimilarityProvider")
163163
void testBucketsSimilarity(List<TestCaseSummary> summaries, int expectedBucketCount) {
164164
List<Map<String, Object>> result = BucketsCalculator.createBuckets(summaries);
165-
var buckets = (List<?>) result.get(0).get("buckets");
165+
var buckets = (List<?>) result.getFirst().get("buckets");
166166
assertThat(buckets).hasSize(expectedBucketCount);
167167
}
168168

src/test/java/dev/dochia/cli/core/util/WordUtilsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,6 @@ void testCollapseEscapedQuotedSegmentsCoverage() {
4646
Assertions.assertThat(WordUtils.normalizeErrorMessage("\\\"foo\\\"")).isEqualTo("\\\"\\\"");
4747

4848
// Empty string
49-
Assertions.assertThat(WordUtils.normalizeErrorMessage("")).isEqualTo("");
49+
Assertions.assertThat(WordUtils.normalizeErrorMessage("")).isEmpty();
5050
}
5151
}

0 commit comments

Comments
 (0)