fix: Fix for #5 - parameters example leaking between ops on the same path

Author: ludovicianul

src/main/java/dev/dochia/cli/core/factory/PlaybookDataFactory.java

@@ -20,6 +20,7 @@
 import dev.dochia.cli.core.util.OpenApiUtils;
 import io.github.ludovicianul.prettylogger.PrettyLogger;
 import io.github.ludovicianul.prettylogger.PrettyLoggerFactory;
+import io.swagger.v3.core.util.Json;
 import io.swagger.v3.oas.models.OpenAPI;
 import io.swagger.v3.oas.models.Operation;
 import io.swagger.v3.oas.models.PathItem;
@@ -159,13 +160,14 @@ private Schema<?> createSyntheticSchemaForGet(List<Parameter> operationParameter
 
             if ((isPathParam || isQueryParam) && filesArguments.isNotUrlParam(parameter.getName()) && StringUtils.isNotBlank(parameter.getName())) {
                 String newParameterName = parameter.getName() + "|" + parameter.getIn();
-                parameter.setSchema(Optional.ofNullable(parameter.getSchema()).orElse(new Schema<>()));
-                parameter.getSchema().setName(newParameterName);
+                Schema<?> originalSchema = Optional.ofNullable(parameter.getSchema()).orElse(new Schema<>());
+                Schema<?> schemaCopy = Json.mapper().convertValue(originalSchema, Schema.class);
+                schemaCopy.setName(newParameterName);
 
-                syntheticSchema.addProperty(parameter.getName(), parameter.getSchema());
-                if (parameter.getSchema().getExample() == null) {
-                    parameter.getSchema().setExample(parameter.getExample());
-                }
+                Object effectiveExample = schemaCopy.getExample() != null ? schemaCopy.getExample() : parameter.getExample();
+                schemaCopy.setExample(effectiveExample);
+
+                syntheticSchema.addProperty(parameter.getName(), schemaCopy);
                 if (parameter.getRequired() != null && parameter.getRequired()) {
                     required.add(parameter.getName());
                 }

src/test/java/dev/dochia/cli/core/factory/PlaybookDataFactoryTest.java

@@ -1330,4 +1330,23 @@ void shouldMergeParametersSameNameDifferentIn() {
         List<Parameter> merged = playbookDataFactory.mergeParameters(pathItem, operation);
         Assertions.assertThat(merged).hasSize(2);
     }
+
+    @Test
+    void shouldNotLeakPostExampleIntoGetQueryParams() throws Exception {
+        Mockito.when(processingArguments.examplesFlags()).thenReturn(new ProcessingArguments.ExamplesFlags(false, false, false, true));
+        List<PlaybookData> dataList = setupPlaybookData("/api/products", "src/test/resources/cross-operation-example-leak.yml");
+
+        List<PlaybookData> getDataList = dataList.stream().filter(d -> d.getMethod() == HttpMethod.GET).toList();
+        Assertions.assertThat(getDataList).isNotEmpty();
+
+        PlaybookData getData = getDataList.getFirst();
+        String payload = getData.getPayload();
+
+        String postLongExample = "images,variantParameters,allCategories,flags";
+
+        Assertions.assertThat(JsonUtils.getVariableFromJson(payload, "$.include")).asString().isEqualTo("images");
+        Assertions.assertThat(JsonUtils.getVariableFromJson(payload, "$.supplierGuid")).asString().isNotEqualTo(postLongExample);
+        Assertions.assertThat(JsonUtils.getVariableFromJson(payload, "$.brandName")).asString().isNotEqualTo(postLongExample);
+        Assertions.assertThat(JsonUtils.getVariableFromJson(payload, "$.changeTimeFrom")).asString().isNotEqualTo(postLongExample);
+    }
 }

src/test/resources/cross-operation-example-leak.yml

@@ -0,0 +1,64 @@
+openapi: 3.0.3
+info:
+  title: Cross-operation example leak regression test
+  version: 1.0.0
+paths:
+  /api/products:
+    post:
+      operationId: createProducts
+      summary: POST products
+      parameters:
+        - name: include
+          in: query
+          example: images,variantParameters,allCategories,flags
+          schema:
+            type: string
+      requestBody:
+        required: true
+        content:
+          application/json:
+            schema:
+              $ref: '#/components/schemas/ProductRequest'
+      responses:
+        '201':
+          description: Created
+    get:
+      operationId: listProducts
+      summary: GET products
+      parameters:
+        - name: include
+          in: query
+          example: images
+          schema:
+            type: string
+        - name: supplierGuid
+          in: query
+          example: 16a67ec6-d957-11e0-b04f-57a43310b768
+          schema:
+            type: string
+        - name: brandName
+          in: query
+          example: AcmeBrand
+          schema:
+            type: string
+        - name: changeTimeFrom
+          in: query
+          example: 2017-02-28T17:04:47+0100
+          schema:
+            type: string
+        - name: page
+          in: query
+          example: 3
+          schema:
+            type: integer
+      responses:
+        '200':
+          description: OK
+components:
+  schemas:
+    ProductRequest:
+      type: object
+      properties:
+        name:
+          type: string
+          example: MyProduct