chore: Some efficiencies in legend command

Author: ludovicianul

src/main/java/dev/dochia/cli/core/command/LegendCommand.java

@@ -5,7 +5,6 @@
 import picocli.CommandLine.ParentCommand;
 
 import java.nio.charset.StandardCharsets;
-import java.time.Instant;
 import java.util.Random;
 import java.util.concurrent.Callable;
 
@@ -36,11 +35,12 @@ public class LegendCommand implements Callable<Integer> {
     @ParentCommand
     Object parent; // optional: access parent config if needed later
 
+    public static final String LINE = "─────────────────────────────";
     private static final String[][] STORY_EN = new String[][]{
             {
-                    "─────────────────────────────",
+                    LINE,
                     "        Dochia’s Legend",
-                    "─────────────────────────────",
+                    LINE,
                     "Baba Dochia climbed the mountain,",
                     "wearing nine coats, one on top of another.",
                     "She thought spring had come,",
@@ -53,10 +53,10 @@ public class LegendCommand implements Callable<Integer> {
                     "Never trust the weather forecast,",
                     "and always test your edge cases. 😉",
                     "",
-                    "─────────────────────────────",
+                    LINE,
                     "Tip: Run `dochia --chaos` to shed",
                     "some coats of your own.",
-                    "─────────────────────────────"
+                    LINE
             }
     };
 
@@ -93,16 +93,12 @@ private Variant chooseVariant() {
         if (ascii) return Variant.ASCII;
 
         // Random choice for the easter egg when no explicit style is set
-        Random rnd = (seed != null) ? new Random(seed) : seededRandom();
+        Random rnd = (seed != null) ? new Random(seed) : new Random();
         int pick = rnd.nextInt(3);
-        return pick == 0 ? Variant.STORY : (pick == 1 ? Variant.HAIKU : Variant.ASCII);
-    }
-
-    private Random seededRandom() {
-        // Derive a seed from current time, PID hash & some bytes to keep variety but reproducible per run
-        long t = Instant.now().toEpochMilli();
-        long mix = t ^ System.identityHashCode(this);
-        return new Random(mix);
+        if (pick == 0) {
+            return Variant.STORY;
+        }
+        return pick == 1 ? Variant.HAIKU : Variant.ASCII;
     }
 
     private String[][] resolveLines(Variant v) {
@@ -114,7 +110,7 @@ private String[][] resolveLines(Variant v) {
     }
 
     private void printBoxed(String[][] content, boolean ansi) {
-        final String top = repeat("─", Math.max(20, Math.min(120, width)));
+        final String top = repeat("─", Math.clamp(width, 20, 120));
         // Only add colored title bars for STORY; keep HAIKU/ASCII clean
         boolean banner = content[0].length > 8; // crude but effective
 

src/test/java/dev/dochia/cli/core/command/LegendCommandTest.java

@@ -45,10 +45,8 @@ void haiku_en_outputsExpectedThreeLines_andNoAnsiWhenNoColor() {
         assertThat(out)
                 .contains("Nine coats on the hill,")
                 .contains("Spring fooled her, winter returned —")
-                .contains("Stone remembers all.");
-
-        // Ensure no ANSI escape sequences when --no-color is set
-        assertThat(out).doesNotContain("\u001B[");
+                .contains("Stone remembers all.")
+                .doesNotContain("\u001B[");
     }
 
     @Test
@@ -59,9 +57,8 @@ void ascii_en_containsAsciiArt_andPunchline_andNoAnsiWhenNoColor() {
                 .contains("   /\\    Baba Dochia climbed high,")
                 .contains("  /  \\   dropping her nine coats…")
                 .contains(" / ❄  \\  …then winter laughed.")
-                .contains("/______\\ Moral: never trust inputs. 😉");
-
-        assertThat(out).doesNotContain("\u001B[");
+                .contains("/______\\ Moral: never trust inputs. 😉")
+                .doesNotContain("\u001B[");
     }
 
     @Test
@@ -76,9 +73,7 @@ void defaultVariant_en_isOneOfKnownOutputs_andNoAnsiWhenNoColor() {
                         .contains("Stone remembers all."),
                 s -> assertThat(s).contains("Baba Dochia climbed high,")
                         .contains("Moral: never trust inputs.")
-        );
-
-        assertThat(out).doesNotContain("\u001B[");
+        ).doesNotContain("\u001B[");
     }
 }