chore: Replace unused variables with _

ludovicianul · ludovicianul · commit fb5f370cf50b · 2025-10-10T21:09:48.000+03:00
diff --git a/README.md b/README.md
@@ -5,7 +5,7 @@
 > simple 🤷‍♀️
 
 [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)
-[![Java Version](https://img.shields.io/badge/Java-21+-blue.svg)](https://openjdk.org)
+[![Java Version](https://img.shields.io/badge/Java-25+-blue.svg)](https://openjdk.org)
 [![GraalVM](https://img.shields.io/badge/GraalVM-Native-orange.svg)](https://www.graalvm.org)
 [![Release](https://img.shields.io/github/v/release/dochia-dev/dochia-cli.svg)](https://github.com/dochia-dev/dochia-cli/releases)
 
diff --git a/src/main/java/dev/dochia/cli/core/context/GlobalContext.java b/src/main/java/dev/dochia/cli/core/context/GlobalContext.java
@@ -259,7 +259,7 @@ public Object getObjectFromPathsReference(String reference) {
             String finalPart = part;
             resolvedDefinition = switch (resolvedDefinition) {
                 case Map<?, ?> map -> map.get(finalPart);
-                case OpenAPI ignored when finalPart.equals("paths") -> openAPI.getPaths();
+                case OpenAPI _ when finalPart.equals("paths") -> openAPI.getPaths();
                 case PathItem item when finalPart.equalsIgnoreCase("parameters") -> extractParameters(item);
                 case PathItem item ->
                         item.readOperationsMap().get(PathItem.HttpMethod.valueOf(finalPart.toUpperCase(Locale.ROOT)));
@@ -272,7 +272,7 @@ public Object getObjectFromPathsReference(String reference) {
                 case Schema<?> schema when "examples".equals(finalPart) -> schema.getExamples();
                 case Schema<?> schema -> extractFromSchema(finalPart, schema, resolvedDefinition);
                 case List<?> asList -> asList.get(Integer.parseInt(finalPart));
-                case Object ignored when "components".equals(finalPart) -> openAPI.getComponents();
+                case Object _ when "components".equals(finalPart) -> openAPI.getComponents();
                 case Components components when "schemas".equals(finalPart) -> components.getSchemas();
                 case Components components when "parameters".equalsIgnoreCase(finalPart) -> components.getParameters();
                 case Components components when "headers".equalsIgnoreCase(finalPart) -> components.getHeaders();
diff --git a/src/main/java/dev/dochia/cli/core/factory/PlaybookDataFactory.java b/src/main/java/dev/dochia/cli/core/factory/PlaybookDataFactory.java
@@ -686,7 +686,7 @@ private Set<DochiaHeader> extractHeaders(Operation operation) {
                     this.inlineSchemaIfNeeded(param);
                     try {
                         headers.add(DochiaHeader.fromHeaderParameter(param));
-                    } catch (IllegalArgumentException e) {
+                    } catch (IllegalArgumentException _) {
                         globalContext.recordError("A valid string could not be generated for the header '" + param.getName() + "' using the pattern '" + param.getSchema().getPattern() + "'. Please consider either changing the pattern or simplifying it.");
                         headers.add(DochiaHeader.from(param.getName(), OpenAPIModelGenerator.DEFAULT_STRING_WHEN_GENERATION_FAILS, param.getRequired()));
                     }
diff --git a/src/main/java/dev/dochia/cli/core/generator/simple/StringGenerator.java b/src/main/java/dev/dochia/cli/core/generator/simple/StringGenerator.java
@@ -278,7 +278,7 @@ public static String callGenerateTwice(Function<GeneratorParams, String> generat
                 LOGGER.debug("Generated value " + initialVersion + " matched " + generatorParams.originalPattern());
                 return initialVersion;
             }
-        } catch (Exception e) {
+        } catch (Exception _) {
             LOGGER.debug("Generator {} failed #atempt 1", generator.getClass().getSimpleName());
         }
         try {
@@ -290,7 +290,7 @@ public static String callGenerateTwice(Function<GeneratorParams, String> generat
                 LOGGER.debug("Generated value with lookaheads removed " + secondVersion + " matched " + generatorParams.originalPattern());
                 return secondVersion;
             }
-        } catch (Exception e) {
+        } catch (Exception _) {
             LOGGER.debug("Generator {} failed #atempt 2", generator.getClass().getSimpleName());
         }
         return null;
@@ -417,7 +417,7 @@ private static boolean isSetOfAlternatives(String regex) {
             } else {
                 return false;
             }
-        } catch (PatternSyntaxException e) {
+        } catch (PatternSyntaxException _) {
             return false;
         }
     }
diff --git a/src/main/java/dev/dochia/cli/core/io/ServiceCaller.java b/src/main/java/dev/dochia/cli/core/io/ServiceCaller.java
@@ -694,7 +694,7 @@ private String replaceRefDataEntry(ServiceData data, Map.Entry<String, Object> e
                 boolean mergeFuzzing = data.getTestedFields().contains(entry.getKey());
                 payload = FuzzingStrategy.replaceField(payload, entry.getKey(), fuzzingStrategy, mergeFuzzing).json();
             }
-        } catch (PathNotFoundException e) {
+        } catch (PathNotFoundException _) {
             logger.debug("Ref data key {} was not found within the payload!", entry.getKey());
         }
         return payload;
diff --git a/src/main/java/dev/dochia/cli/core/openapi/OpenAPIModelGenerator.java b/src/main/java/dev/dochia/cli/core/openapi/OpenAPIModelGenerator.java
@@ -780,7 +780,7 @@ <T> Object formatExampleIfNeeded(Schema<T> property, Object example) {
         if (DochiaModelUtils.isBinarySchema(property) || DochiaModelUtils.isByteArraySchema(property)) {
             try {
                 return Base64.getDecoder().decode((byte[]) example);
-            } catch (IllegalArgumentException e) {
+            } catch (IllegalArgumentException _) {
                 return example;
             }
         }
@@ -980,7 +980,7 @@ private void recordRequestSchema(String propertyName, Schema<?> schema) {
     public String generateAndRecordIfExceptionThrown(String propertyName, String pattern, Supplier<String> toExecute) {
         try {
             return toExecute.get();
-        } catch (Exception e) {
+        } catch (Exception _) {
             globalContext.recordError("A valid string could not be generated for the property '" + propertyName + "' using the pattern '" + pattern + "'. Please consider either changing the pattern or simplifying it.");
             return DEFAULT_STRING_WHEN_GENERATION_FAILS;
         }
diff --git a/src/main/java/dev/dochia/cli/core/playbook/body/RandomResourcesPlaybook.java b/src/main/java/dev/dochia/cli/core/playbook/body/RandomResourcesPlaybook.java
@@ -173,7 +173,7 @@ private static boolean isUuid(String value) {
     try {
       UUID.fromString(value);
       return true;
-    } catch (IllegalArgumentException e) {
+    } catch (IllegalArgumentException _) {
       return false;
     }
   }
@@ -182,7 +182,7 @@ private static boolean isLong(String value) {
     try {
       Long.parseLong(value);
       return true;
-    } catch (NumberFormatException e) {
+    } catch (NumberFormatException _) {
       return false;
     }
   }
diff --git a/src/main/java/dev/dochia/cli/core/playbook/field/base/ExactValuesInFieldsPlaybook.java b/src/main/java/dev/dochia/cli/core/playbook/field/base/ExactValuesInFieldsPlaybook.java
@@ -73,10 +73,10 @@ public Object getBoundaryValue(Schema schema) {
           So we generate a larger one and substring the right size. */
         try {
             return generateWithAdjustedLength(schema, 0);
-        } catch (IllegalArgumentException e) {
+        } catch (IllegalArgumentException _) {
             try {
                 return generateWithAdjustedLength(schema, 15);
-            } catch (Exception ex) {
+            } catch (Exception _) {
                 testCaseListener.recordError("Playbook %s could not generate a value for patten %s, min %s, max %s"
                         .formatted(this.getClass().getSimpleName(), schema.getPattern(), schema.getMinLength(), schema.getMaxLength()));
                 return null;
diff --git a/src/main/java/dev/dochia/cli/core/playbook/stateful/DeletedResourcesNotAvailablePlaybook.java b/src/main/java/dev/dochia/cli/core/playbook/stateful/DeletedResourcesNotAvailablePlaybook.java
@@ -81,7 +81,7 @@ private void checkResponse(HttpResponse response, PlaybookData data) {
     static String getRelativePath(String url) {
         try {
             return URI.create(url).toURL().getPath();
-        } catch (Exception e) {
+        } catch (Exception _) {
             return url;
         }
     }
diff --git a/src/main/java/dev/dochia/cli/core/util/CommonUtils.java b/src/main/java/dev/dochia/cli/core/util/CommonUtils.java
@@ -298,7 +298,7 @@ public static boolean isValidURL(String urlString) {
       URI.create(urlString).toURL();
 
       return true;
-    } catch (Exception e) {
+    } catch (Exception _) {
       return false;
     }
   }
diff --git a/src/main/java/dev/dochia/cli/core/util/ConsoleUtils.java b/src/main/java/dev/dochia/cli/core/util/ConsoleUtils.java
@@ -77,7 +77,7 @@ private ConsoleUtils() {
     public static void initTerminalWidth(CommandLine.Model.CommandSpec spec) {
         try {
             terminalWidth = Math.min(140, spec.usageMessage().width());
-        } catch (Exception e) {
+        } catch (Exception _) {
             terminalWidth = 80;
         }
     }
diff --git a/src/main/java/dev/dochia/cli/core/util/JsonUtils.java b/src/main/java/dev/dochia/cli/core/util/JsonUtils.java
@@ -251,7 +251,7 @@ public static boolean equalAsJson(String json1, String json2) {
         }
         try {
             return JsonPath.parse(json1).jsonString().contentEquals(JsonPath.parse(json2).jsonString());
-        } catch (UnsupportedOperationException e) {
+        } catch (UnsupportedOperationException _) {
             String json1Unescaped = StringEscapeUtils.unescapeJson(json1).replaceAll("(^[\"'])|([\"']$)", "");
             String json2Unescaped = StringEscapeUtils.unescapeJson(json2).replaceAll("(^[\"'])|([\"']$)", "");
             return JsonPath.parse(json1Unescaped).jsonString().contentEquals(JsonPath.parse(json2Unescaped).jsonString());
@@ -299,7 +299,7 @@ public static boolean isValidJson(String text) {
         }
         try {
             var unused = JSON_STRICT_PARSER.fromJson(text, Object.class);
-        } catch (Exception e) {
+        } catch (Exception _) {
             return false;
         }
         return text.contains("{") || text.contains("]");
@@ -331,7 +331,7 @@ public static boolean isPrimitive(String payload, String property) {
         }
         try {
             return testForPrimitiveOrThrow(payload, property);
-        } catch (InvalidPathException e) {
+        } catch (InvalidPathException _) {
             LOGGER.debug("Invalid path {}", property);
             return false;
         }
@@ -350,7 +350,7 @@ public static boolean isObject(String payload, String property) {
         }
         try {
             return !testForPrimitiveOrThrow(payload, property);
-        } catch (InvalidPathException e) {
+        } catch (InvalidPathException _) {
             return false;
         }
     }
@@ -368,7 +368,7 @@ public static boolean isArray(String payload, String property) {
         }
         try {
             return testForPredicateOrThrow(payload, property, JsonNode::isArray);
-        } catch (InvalidPathException e) {
+        } catch (InvalidPathException _) {
             return false;
         }
     }
@@ -397,7 +397,7 @@ public static String deleteNode(String payload, String node) {
         if (StringUtils.isNotBlank(payload)) {
             try {
                 return JsonPath.parse(payload).delete(sanitizeToJsonPath(node)).jsonString();
-            } catch (PathNotFoundException e) {
+            } catch (PathNotFoundException _) {
                 return payload;
             }
         }
@@ -453,7 +453,7 @@ public static Object getVariableFromJson(String jsonPayload, String value) {
         try {
             DocumentContext jsonDoc = JsonPath.parse(jsonPayload);
             return jsonDoc.read(JsonUtils.sanitizeToJsonPath(value));
-        } catch (JsonPathException | IllegalArgumentException e) {
+        } catch (JsonPathException | IllegalArgumentException _) {
             LOGGER.debug("Expected variable {} was not found. Setting to NOT_SET", value);
             return NOT_SET;
         }
diff --git a/src/test/java/dev/dochia/cli/core/playbook/body/HttpMethodsPlaybookTest.java b/src/test/java/dev/dochia/cli/core/playbook/body/HttpMethodsPlaybookTest.java
@@ -146,19 +146,4 @@ void givenAnOperation_whenCallingTheHttpMethodsPlaybookAndTheServiceResponsesWit
         httpMethodsPlaybook.run(data);
         Mockito.verify(testCaseListener, Mockito.times(7)).reportResultWarn(Mockito.any(), Mockito.any(), Mockito.anyString(), Mockito.eq("POST"), AdditionalMatchers.aryEq(new Object[]{405, "POST"}));
     }
-
-    @Test
-    void givenAnOperation_whenCallingTheHttpMethodsPlaybookAndTheServiceResponsesWith405AndValidAllowHeader_thenInfoIsReported() {
-        PlaybookData data = PlaybookData.builder().pathItem(new PathItem()).reqSchema(new StringSchema()).requestContentTypes(List.of("application/json")).build();
-        HttpResponse httpResponse = HttpResponse.builder()
-                .body("{}")
-                .responseCode(405)
-                .httpMethod("POST")
-                .headers(List.of(new KeyValuePair<>("Allow", "GET, PUT, DELETE")))
-                .build();
-        Mockito.when(serviceCaller.call(Mockito.any())).thenReturn(httpResponse);
-
-        httpMethodsPlaybook.run(data);
-        Mockito.verify(testCaseListener, Mockito.times(7)).reportResultInfo(Mockito.any(), Mockito.any(), Mockito.anyString(), AdditionalMatchers.aryEq(new Object[]{"POST", 405}));
-    }
 }
diff --git a/src/test/java/dev/dochia/cli/core/report/BucketsCalculatorTest.java b/src/test/java/dev/dochia/cli/core/report/BucketsCalculatorTest.java
@@ -85,7 +85,7 @@ private static void setField(Object obj, String field, Object value) {
             var f = obj.getClass().getDeclaredField(field);
             f.setAccessible(true);
             f.set(obj, value);
-        } catch (Exception ignored) {
+        } catch (Exception _) {
             //ignore as it doesn't matter for the test
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -686,7 +686,7 @@ private Set<DochiaHeader> extractHeaders(Operation operation) {`
`686`	`686`	`this.inlineSchemaIfNeeded(param);`
`687`	`687`	`try {`
`688`	`688`	`headers.add(DochiaHeader.fromHeaderParameter(param));`
`689`		`- } catch (IllegalArgumentException e) {`
	`689`	`+ } catch (IllegalArgumentException _) {`
`690`	`690`	`globalContext.recordError("A valid string could not be generated for the header '" + param.getName() + "' using the pattern '" + param.getSchema().getPattern() + "'. Please consider either changing the pattern or simplifying it.");`
`691`	`691`	`headers.add(DochiaHeader.from(param.getName(), OpenAPIModelGenerator.DEFAULT_STRING_WHEN_GENERATION_FAILS, param.getRequired()));`
`692`	`692`	`}`
Original file line number	Diff line number	Diff line change
`@@ -278,7 +278,7 @@ public static String callGenerateTwice(Function<GeneratorParams, String> generat`
`278`	`278`	`LOGGER.debug("Generated value " + initialVersion + " matched " + generatorParams.originalPattern());`
`279`	`279`	`return initialVersion;`
`280`	`280`	`}`
`281`		`- } catch (Exception e) {`
	`281`	`+ } catch (Exception _) {`
`282`	`282`	`LOGGER.debug("Generator {} failed #atempt 1", generator.getClass().getSimpleName());`
`283`	`283`	`}`
`284`	`284`	`try {`
`@@ -290,7 +290,7 @@ public static String callGenerateTwice(Function<GeneratorParams, String> generat`
`290`	`290`	`LOGGER.debug("Generated value with lookaheads removed " + secondVersion + " matched " + generatorParams.originalPattern());`
`291`	`291`	`return secondVersion;`
`292`	`292`	`}`
`293`		`- } catch (Exception e) {`
	`293`	`+ } catch (Exception _) {`
`294`	`294`	`LOGGER.debug("Generator {} failed #atempt 2", generator.getClass().getSimpleName());`
`295`	`295`	`}`
`296`	`296`	`return null;`
`@@ -417,7 +417,7 @@ private static boolean isSetOfAlternatives(String regex) {`
`417`	`417`	`} else {`
`418`	`418`	`return false;`
`419`	`419`	`}`
`420`		`- } catch (PatternSyntaxException e) {`
	`420`	`+ } catch (PatternSyntaxException _) {`
`421`	`421`	`return false;`
`422`	`422`	`}`
`423`	`423`	`}`
Original file line number	Diff line number	Diff line change
`@@ -694,7 +694,7 @@ private String replaceRefDataEntry(ServiceData data, Map.Entry<String, Object> e`
`694`	`694`	`boolean mergeFuzzing = data.getTestedFields().contains(entry.getKey());`
`695`	`695`	`payload = FuzzingStrategy.replaceField(payload, entry.getKey(), fuzzingStrategy, mergeFuzzing).json();`
`696`	`696`	`}`
`697`		`- } catch (PathNotFoundException e) {`
	`697`	`+ } catch (PathNotFoundException _) {`
`698`	`698`	`logger.debug("Ref data key {} was not found within the payload!", entry.getKey());`
`699`	`699`	`}`
`700`	`700`	`return payload;`
Original file line number	Diff line number	Diff line change
`@@ -780,7 +780,7 @@ <T> Object formatExampleIfNeeded(Schema<T> property, Object example) {`
`780`	`780`	`if (DochiaModelUtils.isBinarySchema(property) \|\| DochiaModelUtils.isByteArraySchema(property)) {`
`781`	`781`	`try {`
`782`	`782`	`return Base64.getDecoder().decode((byte[]) example);`
`783`		`- } catch (IllegalArgumentException e) {`
	`783`	`+ } catch (IllegalArgumentException _) {`
`784`	`784`	`return example;`
`785`	`785`	`}`
`786`	`786`	`}`
`@@ -980,7 +980,7 @@ private void recordRequestSchema(String propertyName, Schema<?> schema) {`
`980`	`980`	`public String generateAndRecordIfExceptionThrown(String propertyName, String pattern, Supplier<String> toExecute) {`
`981`	`981`	`try {`
`982`	`982`	`return toExecute.get();`
`983`		`- } catch (Exception e) {`
	`983`	`+ } catch (Exception _) {`
`984`	`984`	`globalContext.recordError("A valid string could not be generated for the property '" + propertyName + "' using the pattern '" + pattern + "'. Please consider either changing the pattern or simplifying it.");`
`985`	`985`	`return DEFAULT_STRING_WHEN_GENERATION_FAILS;`
`986`	`986`	`}`
Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ private static boolean isUuid(String value) {`
`173`	`173`	`try {`
`174`	`174`	`UUID.fromString(value);`
`175`	`175`	`return true;`
`176`		`- } catch (IllegalArgumentException e) {`
	`176`	`+ } catch (IllegalArgumentException _) {`
`177`	`177`	`return false;`
`178`	`178`	`}`
`179`	`179`	`}`
`@@ -182,7 +182,7 @@ private static boolean isLong(String value) {`
`182`	`182`	`try {`
`183`	`183`	`Long.parseLong(value);`
`184`	`184`	`return true;`
`185`		`- } catch (NumberFormatException e) {`
	`185`	`+ } catch (NumberFormatException _) {`
`186`	`186`	`return false;`
`187`	`187`	`}`
`188`	`188`	`}`
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ private void checkResponse(HttpResponse response, PlaybookData data) {`
`81`	`81`	`static String getRelativePath(String url) {`
`82`	`82`	`try {`
`83`	`83`	`return URI.create(url).toURL().getPath();`
`84`		`- } catch (Exception e) {`
	`84`	`+ } catch (Exception _) {`
`85`	`85`	`return url;`
`86`	`86`	`}`
`87`	`87`	`}`
Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,7 @@ public static boolean isValidURL(String urlString) {`
`298`	`298`	`URI.create(urlString).toURL();`
`299`	`299`
`300`	`300`	`return true;`
`301`		`- } catch (Exception e) {`
	`301`	`+ } catch (Exception _) {`
`302`	`302`	`return false;`
`303`	`303`	`}`
`304`	`304`	`}`