fix: Fix issue with parameter on GET requests not being parsed for openapi 3.1.x

Author: ludovicianul

src/main/java/dev/dochia/cli/core/factory/PlaybookDataFactory.java

@@ -161,7 +161,7 @@ private Schema<?> createSyntheticSchemaForGet(List<Parameter> operationParameter
             if ((isPathParam || isQueryParam) && filesArguments.isNotUrlParam(parameter.getName()) && StringUtils.isNotBlank(parameter.getName())) {
                 String newParameterName = parameter.getName() + "|" + parameter.getIn();
                 Schema<?> originalSchema = Optional.ofNullable(parameter.getSchema()).orElse(new Schema<>());
-                Schema<?> schemaCopy = Json.mapper().convertValue(originalSchema, Schema.class);
+                Schema<?> schemaCopy = copySchema(originalSchema);
                 schemaCopy.setName(newParameterName);
 
                 Object effectiveExample = schemaCopy.getExample() != null ? schemaCopy.getExample() : parameter.getExample();
@@ -177,6 +177,22 @@ private Schema<?> createSyntheticSchemaForGet(List<Parameter> operationParameter
         return syntheticSchema;
     }
 
+    /**
+     * Creates a copy of a Schema preserving the original class type.
+     * This is needed because {@code Json.mapper().convertValue(schema, Schema.class)} converts
+     * OpenAPI 3.1 JsonSchema instances (which store type in {@code types} Set) into ObjectSchema,
+     * losing the original type information.
+     */
+    @SuppressWarnings("unchecked")
+    private static Schema<?> copySchema(Schema<?> originalSchema) {
+        Schema<?> schemaCopy = Json.mapper().convertValue(originalSchema, Schema.class);
+        Set<String> originalTypes = originalSchema.getTypes();
+        if (originalTypes != null && !originalTypes.isEmpty()) {
+            schemaCopy.setTypes(new HashSet<>(originalTypes));
+        }
+        return schemaCopy;
+    }
+
     List<Parameter> getResolvedParameters(List<Parameter> operationParameters) {
         return Optional.ofNullable(operationParameters)
                 .orElseGet(Collections::emptyList)

src/main/java/dev/dochia/cli/core/util/DochiaModelUtils.java

@@ -150,11 +150,9 @@ public static boolean isType(Schema<?> schema, String typeToTest) {
         if (schema == null) {
             return false;
         }
-        if (schema instanceof JsonSchema jsonSchema) {
-            return Optional.ofNullable(jsonSchema.getTypes())
-                    .orElse(Set.of())
-                    .stream()
-                    .anyMatch(type -> type.equalsIgnoreCase(typeToTest));
+        Set<String> types = schema.getTypes();
+        if (types != null && !types.isEmpty()) {
+            return types.stream().anyMatch(type -> type.equalsIgnoreCase(typeToTest));
         }
 
         return typeToTest.equalsIgnoreCase(schema.getType());

src/test/java/dev/dochia/cli/core/factory/PlaybookDataFactoryTest.java

@@ -734,6 +734,17 @@ void shouldGenerateApiResponsesWithSimpleSchemas() throws Exception {
         Assertions.assertThat(response204).isEqualTo("{}");
     }
 
+    @Test
+    void shouldGenerateValuesForPathParamsInJsonContract() throws Exception {
+        List<PlaybookData> dataList = setupPlaybookData("/customers/{customerId}/orders", "src/test/resources/openapi_31_params.json");
+        Assertions.assertThat(dataList).isNotEmpty();
+        PlaybookData getData = dataList.stream().filter(fd -> fd.getMethod() == HttpMethod.GET).findFirst().orElseThrow();
+        String payload = getData.getPayload();
+        Object customerId = JsonUtils.getVariableFromJson(payload, "$.customerId");
+        Assertions.assertThat(customerId).isNotNull();
+        Assertions.assertThat(customerId.toString()).isNotEqualTo("NOT_SET").isNotEmpty();
+    }
+
     @Test
     void shouldGenerateRequestWhenArrayOfArrayOfString() throws Exception {
         Mockito.when(processingArguments.getSelfReferenceDepth()).thenReturn(5);

src/test/resources/openapi_31_params.json

@@ -0,0 +1,85 @@
+{
+  "openapi": "3.1.0",
+  "info": {
+    "title": "Custom API Project",
+    "description": "Expose stuff",
+    "version": "1.0.0"
+  },
+  "servers": [
+    {
+      "url": "http://localhost:8080",
+      "description": "Generated server url"
+    }
+  ],
+  "tags": [
+    {
+      "name": "Customers",
+      "description": "Manage customer information"
+    }
+  ],
+  "paths": {
+    "/customers/{customerId}/orders": {
+      "get": {
+        "tags": [
+          "Customers"
+        ],
+        "summary": "Get orders for customer",
+        "description": "Returns the list of orders for the specified customer.",
+        "operationId": "getOrdersForCustomer",
+        "parameters": [
+          {
+            "name": "customerId",
+            "in": "path",
+            "description": "An external reference for the customer",
+            "required": true,
+            "schema": {
+              "type": "string",
+              "maxLength": 64,
+              "minLength": 3,
+              "pattern": "[A-Za-z0-9_-]+"
+            }
+          },
+          {
+            "name": "CorrelationId",
+            "in": "header",
+            "description": "It allows traceability in a distributed environment",
+            "required": true,
+            "schema": {
+              "type": "string",
+              "format": "uuid"
+            }
+          }
+        ],
+        "responses": {
+          "200": {
+            "description": "Successful response with list of orders",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "type": "array",
+                  "items": {
+                    "type": "string"
+                  }
+                }
+              }
+            }
+          }
+        },
+        "security": [
+          {
+            "BearerAuth": []
+          }
+        ]
+      }
+    }
+  },
+  "components": {
+    "securitySchemes": {
+      "bearerAuth": {
+        "type": "http",
+        "scheme": "bearer",
+        "bearerFormat": "JWT"
+      }
+    }
+  }
+}