Skip to content

Commit 08cf36d

Browse files
authored
Merge pull request #1303 from thaJeztah/remove_buildkit_experimental_annotations
Remove "experimental" annotations for buildkit
2 parents ca78259 + a500c39 commit 08cf36d

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

cli/command/image/build.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,10 +155,8 @@ func NewBuildCommand(dockerCli command.Cli) *cobra.Command {
155155
flags.SetAnnotation("stream", "version", []string{"1.31"})
156156

157157
flags.StringVar(&options.progress, "progress", "auto", "Set type of progress output (only if BuildKit enabled) (auto, plain, tty). Use plain to show container output")
158-
flags.SetAnnotation("progress", "experimental", nil)
159158

160159
flags.StringArrayVar(&options.secrets, "secret", []string{}, "Secret file to expose to the build (only if BuildKit enabled): id=mysecret,src=/local/secret")
161-
flags.SetAnnotation("secret", "experimental", nil)
162160
flags.SetAnnotation("secret", "version", []string{"1.39"})
163161
return cmd
164162
}

cli/command/image/build_session.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ import (
2828
const clientSessionRemote = "client-session"
2929

3030
func isSessionSupported(dockerCli command.Cli) bool {
31+
if versions.GreaterThanOrEqualTo(dockerCli.Client().ClientVersion(), "1.39") {
32+
return true
33+
}
3134
return dockerCli.ServerInfo().HasExperimental && versions.GreaterThanOrEqualTo(dockerCli.Client().ClientVersion(), "1.31")
3235
}
3336

0 commit comments

Comments
 (0)