cli/command/image: close ProgressReader

thaJeztah · thaJeztah · commit 0b70f6e81765 · 2026-02-19T09:46:26.000+01:00
progress.NewProgressReader implements io.ReadCloser. client.ImageBuild only
requests an io.Reader, and there's some code in place to assert if the passed
io.Reader was an io.ReadCloser, but let's make sure it's closed just in case.

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/cli/command/image/build.go b/cli/command/image/build.go
@@ -315,9 +315,10 @@ func runBuild(ctx context.Context, dockerCli command.Cli, options buildOptions)
 		buildCtx = dockerfileCtx
 	}
 
-	var body io.Reader
+	var body io.ReadCloser
 	if buildCtx != nil {
 		body = progress.NewProgressReader(buildCtx, progressOutput, 0, "", "Sending build context to Docker daemon")
+		defer func() { _ = body.Close() }()
 	}
 
 	configFile := dockerCli.ConfigFile()

Original file line number	Diff line number	Diff line change
`@@ -315,9 +315,10 @@ func runBuild(ctx context.Context, dockerCli command.Cli, options buildOptions)`
`315`	`315`	`buildCtx = dockerfileCtx`
`316`	`316`	`}`
`317`	`317`
`318`		`- var body io.Reader`
	`318`	`+ var body io.ReadCloser`
`319`	`319`	`if buildCtx != nil {`
`320`	`320`	`body = progress.NewProgressReader(buildCtx, progressOutput, 0, "", "Sending build context to Docker daemon")`
	`321`	`+ defer func() { _ = body.Close() }()`
`321`	`322`	`}`
`322`	`323`
`323`	`324`	`configFile := dockerCli.ConfigFile()`