Skip to content

Commit 18c44e0

Browse files
Check and return error while creating kubernetes secret and config maps.
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
1 parent f1b1161 commit 18c44e0

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

cli/command/stack/kubernetes/conversion.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ func podToTask(pod apiv1.Pod) swarm.Task {
3737
},
3838
}
3939

40-
pod.GetLabels()
4140
return task
4241
}
4342

cli/command/stack/kubernetes/deploy.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,9 @@ func createFileBasedConfigMaps(stackName string, globalConfigs map[string]compos
9494
return err
9595
}
9696

97-
configMap := toConfigMap(stackName, name, fileName, content)
98-
configMaps.Create(configMap)
97+
if _, err := configMaps.Create(toConfigMap(stackName, name, fileName, content)); err != nil {
98+
return err
99+
}
99100
}
100101

101102
return nil
@@ -124,8 +125,9 @@ func createFileBasedSecrets(stackName string, globalSecrets map[string]composeTy
124125
return err
125126
}
126127

127-
secret := toSecret(stackName, name, fileName, content)
128-
secrets.Create(secret)
128+
if _, err := secrets.Create(toSecret(stackName, name, fileName, content)); err != nil {
129+
return err
130+
}
129131
}
130132

131133
return nil

0 commit comments

Comments
 (0)