cli/command/volume: TestVolumeCreateClusterOpts: minor fixes and refactor

- assert unhandled error
- discard stdout/stderr output

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Author: thaJeztah

cli/command/volume/create_test.go

@@ -233,25 +233,27 @@ func TestVolumeCreateClusterOpts(t *testing.T) {
 	})
 
 	cmd := newCreateCommand(cli)
+	cmd.SetOut(io.Discard)
+	cmd.SetErr(io.Discard)
 	cmd.SetArgs([]string{"name"})
-	cmd.Flags().Set("driver", "csi")
-	cmd.Flags().Set("group", "gronp")
-	cmd.Flags().Set("scope", "multi")
-	cmd.Flags().Set("sharing", "onewriter")
-	cmd.Flags().Set("type", "mount")
-	cmd.Flags().Set("sharing", "onewriter")
-	cmd.Flags().Set("required-bytes", "1234")
-	cmd.Flags().Set("limit-bytes", "567890")
+	assert.Check(t, cmd.Flags().Set("driver", "csi"))
+	assert.Check(t, cmd.Flags().Set("group", "gronp"))
+	assert.Check(t, cmd.Flags().Set("scope", "multi"))
+	assert.Check(t, cmd.Flags().Set("sharing", "onewriter"))
+	assert.Check(t, cmd.Flags().Set("type", "mount"))
+	assert.Check(t, cmd.Flags().Set("sharing", "onewriter"))
+	assert.Check(t, cmd.Flags().Set("required-bytes", "1234"))
+	assert.Check(t, cmd.Flags().Set("limit-bytes", "567890"))
 
-	cmd.Flags().Set("secret", "key1=secret1")
-	cmd.Flags().Set("secret", "key2=secret2")
+	assert.Check(t, cmd.Flags().Set("secret", "key1=secret1"))
+	assert.Check(t, cmd.Flags().Set("secret", "key2=secret2"))
 
-	cmd.Flags().Set("topology-required", "region=R1,zone=Z1")
-	cmd.Flags().Set("topology-required", "region=R1,zone=Z2")
-	cmd.Flags().Set("topology-required", "region=R1,zone=Z3")
+	assert.Check(t, cmd.Flags().Set("topology-required", "region=R1,zone=Z1"))
+	assert.Check(t, cmd.Flags().Set("topology-required", "region=R1,zone=Z2"))
+	assert.Check(t, cmd.Flags().Set("topology-required", "region=R1,zone=Z3"))
 
-	cmd.Flags().Set("topology-preferred", "region=R1,zone=Z2")
-	cmd.Flags().Set("topology-preferred", "region=R1,zone=Z3")
+	assert.Check(t, cmd.Flags().Set("topology-preferred", "region=R1,zone=Z2"))
+	assert.Check(t, cmd.Flags().Set("topology-preferred", "region=R1,zone=Z3"))
 
-	cmd.Execute()
+	assert.NilError(t, cmd.Execute())
 }