Skip to content

Commit a10a1e6

Browse files
committed
builder/remotecontext: remove unused named and "naked" returns
Also renamed some vars for clarity, renamed a error-returns to prevent shadowing, and fixed some linter warnings about unhandled errors. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent 75f791d commit a10a1e6

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

cli/command/image/build/internal/git/gitutils.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ func Clone(remoteURL string, opts ...CloneOption) (string, error) {
4646
return repo.clone()
4747
}
4848

49-
func (repo gitRepo) clone() (checkoutDir string, err error) {
49+
func (repo gitRepo) clone() (checkoutDir string, retErr error) {
5050
fetch := fetchArgs(repo.remote, repo.ref)
5151

5252
root, err := os.MkdirTemp("", "docker-build-git")
@@ -55,8 +55,8 @@ func (repo gitRepo) clone() (checkoutDir string, err error) {
5555
}
5656

5757
defer func() {
58-
if err != nil {
59-
os.RemoveAll(root)
58+
if retErr != nil {
59+
_ = os.RemoveAll(root)
6060
}
6161
}()
6262

0 commit comments

Comments
 (0)