cli-plugins/hooks: limit maximum number of lines / messages

thaJeztah · thaJeztah · commit add13abe8e6b · 2026-04-21T19:41:13.000+02:00
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/cli-plugins/hooks/template.go b/cli-plugins/hooks/template.go
@@ -13,6 +13,8 @@ import (
 	"github.com/spf13/cobra"
 )
 
+const maxMessages = 10
+
 func ParseTemplate(hookTemplate string, cmd *cobra.Command) ([]string, error) {
 	out := hookTemplate
 	if strings.Contains(hookTemplate, "{{") {
@@ -38,7 +40,10 @@ func ParseTemplate(hookTemplate string, cmd *cobra.Command) ([]string, error) {
 		}
 		out = b.String()
 	}
-	return strings.Split(out, "\n"), nil
+	if n := strings.Count(out, "\n"); n > maxMessages {
+		return nil, fmt.Errorf("hook template contains too many messages (%d): maximum is %d", n, maxMessages)
+	}
+	return strings.SplitN(out, "\n", maxMessages), nil
 }
 
 var ErrHookTemplateParse = errors.New("failed to parse hook template")

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,8 @@ import (`
`13`	`13`	`"github.com/spf13/cobra"`
`14`	`14`	`)`
`15`	`15`
	`16`	`+const maxMessages = 10`
	`17`	`+`
`16`	`18`	`func ParseTemplate(hookTemplate string, cmd *cobra.Command) ([]string, error) {`
`17`	`19`	`out := hookTemplate`
`18`	`20`	`if strings.Contains(hookTemplate, "{{") {`
`@@ -38,7 +40,10 @@ func ParseTemplate(hookTemplate string, cmd *cobra.Command) ([]string, error) {`
`38`	`40`	`}`
`39`	`41`	`out = b.String()`
`40`	`42`	`}`
`41`		`- return strings.Split(out, "\n"), nil`
	`43`	`+ if n := strings.Count(out, "\n"); n > maxMessages {`
	`44`	`+ return nil, fmt.Errorf("hook template contains too many messages (%d): maximum is %d", n, maxMessages)`
	`45`	`+ }`
	`46`	`+ return strings.SplitN(out, "\n", maxMessages), nil`
`42`	`47`	`}`
`43`	`48`
`44`	`49`	`var ErrHookTemplateParse = errors.New("failed to parse hook template")`