Skip to content

Commit b1ce915

Browse files
authored
Merge pull request #3517 from crazy-max/fix-version-quad
trim leading 0 for minor in the version quad
2 parents 58d425d + 5258455 commit b1ce915

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

scripts/build/mkversioninfo

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ set -eu
77

88
# Create version quad for Windows of the form major.minor.patch.build
99
VERSION_QUAD=$(printf "%s" "$VERSION" | sed -re 's/^([0-9.]*).*$/\1/' | sed -re 's/\.$//' | sed -re 's/^[0-9]+$/\0\.0/' | sed -re 's/^[0-9]+\.[0-9]+$/\0\.0/' | sed -re 's/^[0-9]+\.[0-9]+\.[0-9]+$/\0\.0/')
10+
VERSION_MAJOR=$(echo "${VERSION_QUAD:-0}" | cut -d. -f1)
11+
VERSION_MINOR=$(echo "${VERSION_QUAD:-0}" | cut -d. -f2)
12+
VERSION_PATCH=$(echo "${VERSION_QUAD:-0}" | cut -d. -f3)
13+
VERSION_BUILD=$(echo "${VERSION_QUAD:-0}" | cut -d. -f4)
1014

1115
# Generate versioninfo.json to be able to create a syso file which contains
1216
# Microsoft Windows Version Information and an icon using goversioninfo.
@@ -17,10 +21,10 @@ cat > ./cli/winresources/versioninfo.json <<EOL
1721
"FixedFileInfo":
1822
{
1923
"FileVersion": {
20-
"Major": $(echo "${VERSION_QUAD:-0}" | cut -d. -f1),
21-
"Minor": $(echo "${VERSION_QUAD:-0}" | cut -d. -f2),
22-
"Patch": $(echo "${VERSION_QUAD:-0}" | cut -d. -f3),
23-
"Build": $(echo "${VERSION_QUAD:-0}" | cut -d. -f4)
24+
"Major": ${VERSION_MAJOR},
25+
"Minor": ${VERSION_MINOR#0},
26+
"Patch": ${VERSION_PATCH},
27+
"Build": ${VERSION_BUILD}
2428
},
2529
"FileFlagsMask": "3f",
2630
"FileFlags ": "00",

0 commit comments

Comments
 (0)