|
| 1 | +package image |
| 2 | + |
| 3 | +import ( |
| 4 | + "strings" |
| 5 | + "testing" |
| 6 | + "time" |
| 7 | + |
| 8 | + "github.com/docker/cli/e2e/internal/fixtures" |
| 9 | + "gotest.tools/v3/assert" |
| 10 | + "gotest.tools/v3/icmd" |
| 11 | +) |
| 12 | + |
| 13 | +// Regression test for https://github.com/docker/cli/issues/5963 |
| 14 | +func TestPullPushPrivateRepository(t *testing.T) { |
| 15 | + t.Parallel() |
| 16 | + |
| 17 | + for _, tc := range []struct { |
| 18 | + name string |
| 19 | + registryPrefix string |
| 20 | + tagSuffix string |
| 21 | + }{ |
| 22 | + {name: "insecure", registryPrefix: "privateregistry:5001", tagSuffix: "private"}, |
| 23 | + {name: "tls", registryPrefix: "tlsregistry:5003", tagSuffix: "tls"}, |
| 24 | + } { |
| 25 | + t.Run(tc.name, func(t *testing.T) { |
| 26 | + t.Parallel() |
| 27 | + |
| 28 | + dir := fixtures.SetupConfigFile(t) |
| 29 | + t.Cleanup(dir.Remove) |
| 30 | + emptyConfigDir := t.TempDir() |
| 31 | + |
| 32 | + sourceImage := fixtures.AlpineImage |
| 33 | + privateImage := tc.registryPrefix + "/private/alpine:test-" + tc.tagSuffix + "-pull-push" |
| 34 | + |
| 35 | + runWithPrivateRegistryRetry(t, |
| 36 | + icmd.Command("docker", "pull", sourceImage), |
| 37 | + ).Assert(t, icmd.Success) |
| 38 | + t.Cleanup(func() { |
| 39 | + icmd.RunCommand("docker", "image", "rm", "-f", privateImage).Assert(t, icmd.Success) |
| 40 | + }) |
| 41 | + |
| 42 | + icmd.RunCommand("docker", "tag", sourceImage, privateImage).Assert(t, icmd.Success) |
| 43 | + |
| 44 | + pushNoAuth := runWithPrivateRegistryRetry(t, |
| 45 | + icmd.Command("docker", "push", privateImage), |
| 46 | + fixtures.WithConfig(emptyConfigDir), |
| 47 | + ) |
| 48 | + pushNoAuth.Assert(t, icmd.Expected{ExitCode: 1}) |
| 49 | + assertAuthDenied(t, pushNoAuth) |
| 50 | + |
| 51 | + pushWithAuth := runWithPrivateRegistryRetry(t, |
| 52 | + icmd.Command("docker", "push", privateImage), |
| 53 | + fixtures.WithConfig(dir.Path()), |
| 54 | + ) |
| 55 | + pushWithAuth.Assert(t, icmd.Success) |
| 56 | + // Docker omits the tag in the "push refers to repository" line; strip it before asserting. |
| 57 | + privateRepo := privateImage[:strings.LastIndex(privateImage, ":")] |
| 58 | + assert.Check(t, strings.Contains(pushWithAuth.Combined(), "The push refers to repository ["+privateRepo+"]"), pushWithAuth.Combined()) |
| 59 | + |
| 60 | + icmd.RunCommand("docker", "image", "rm", "-f", privateImage).Assert(t, icmd.Success) |
| 61 | + |
| 62 | + pullNoAuth := runWithPrivateRegistryRetry(t, |
| 63 | + icmd.Command("docker", "pull", privateImage), |
| 64 | + fixtures.WithConfig(emptyConfigDir), |
| 65 | + ) |
| 66 | + pullNoAuth.Assert(t, icmd.Expected{ExitCode: 1}) |
| 67 | + assertAuthDenied(t, pullNoAuth) |
| 68 | + |
| 69 | + pullWithAuth := runWithPrivateRegistryRetry(t, |
| 70 | + icmd.Command("docker", "pull", privateImage), |
| 71 | + fixtures.WithConfig(dir.Path()), |
| 72 | + ) |
| 73 | + pullWithAuth.Assert(t, icmd.Success) |
| 74 | + assert.Check(t, strings.Contains(pullWithAuth.Combined(), privateImage), pullWithAuth.Combined()) |
| 75 | + }) |
| 76 | + } |
| 77 | +} |
| 78 | + |
| 79 | +func assertAuthDenied(t *testing.T, result *icmd.Result) { |
| 80 | + t.Helper() |
| 81 | + output := result.Combined() |
| 82 | + if isPrivateRegistryTransient(output) { |
| 83 | + t.Fatalf("private registry unavailable while expecting auth failure: %s", output) |
| 84 | + } |
| 85 | + |
| 86 | + assert.Assert(t, |
| 87 | + strings.Contains(output, "requested access to the resource is denied") || |
| 88 | + strings.Contains(output, "no basic auth credentials") || |
| 89 | + strings.Contains(output, "unauthorized") || |
| 90 | + strings.Contains(output, "authentication required"), |
| 91 | + output, |
| 92 | + ) |
| 93 | +} |
| 94 | + |
| 95 | +func runWithPrivateRegistryRetry(t *testing.T, cmd icmd.Cmd, opts ...icmd.CmdOp) *icmd.Result { |
| 96 | + t.Helper() |
| 97 | + |
| 98 | + deadline := time.Now().Add(90 * time.Second) |
| 99 | + for { |
| 100 | + result := icmd.RunCmd(cmd, opts...) |
| 101 | + output := result.Combined() |
| 102 | + if isPrivateRegistryTransient(output) { |
| 103 | + if time.Now().Before(deadline) { |
| 104 | + t.Logf("waiting for private registry availability: %s", output) |
| 105 | + time.Sleep(500 * time.Millisecond) |
| 106 | + continue |
| 107 | + } |
| 108 | + } |
| 109 | + return result |
| 110 | + } |
| 111 | +} |
| 112 | + |
| 113 | +func isPrivateRegistryTransient(output string) bool { |
| 114 | + return strings.Contains(output, "lookup privateregistry") || |
| 115 | + strings.Contains(output, "lookup tlsregistry") || |
| 116 | + strings.Contains(output, "lookup registry") || |
| 117 | + strings.Contains(output, "no such host") || |
| 118 | + strings.Contains(output, "server misbehaving") || |
| 119 | + strings.Contains(output, "Temporary failure in name resolution") || |
| 120 | + strings.Contains(output, "connection refused") || |
| 121 | + strings.Contains(output, "i/o timeout") || |
| 122 | + strings.Contains(output, "TLS handshake timeout") || |
| 123 | + strings.Contains(output, "context deadline exceeded") || |
| 124 | + strings.Contains(output, "connection reset by peer") || |
| 125 | + strings.Contains(output, "unexpected EOF") |
| 126 | +} |
0 commit comments