cli: container: remove logging in wait-for-exit paths

Because these paths are used for detached cases, you can end up seeing
"errors" due to not being able to get the exit code, when in reality the
context is timing our or being cancelled. I'm not sure how common this
is on x86, but I can see it all the time on arm64 -- and these error
messages seem quite noisy to me.

Signed-off-by: Aleksa Sarai <asarai@suse.de>

Author: cyphar

cli/command/container/utils.go

@@ -10,7 +10,6 @@ import (
 	"github.com/docker/docker/api/types/events"
 	"github.com/docker/docker/api/types/filters"
 	"github.com/docker/docker/api/types/versions"
-	"github.com/sirupsen/logrus"
 )
 
 func waitExitOrRemoved(ctx context.Context, dockerCli command.Cli, containerID string, waitRemove bool) <-chan int {
@@ -38,13 +37,11 @@ func waitExitOrRemoved(ctx context.Context, dockerCli command.Cli, containerID s
 		select {
 		case result := <-resultC:
 			if result.Error != nil {
-				logrus.Errorf("Error waiting for container: %v", result.Error.Message)
 				statusC <- 125
 			} else {
 				statusC <- int(result.StatusCode)
 			}
 		case err := <-errC:
-			logrus.Errorf("error waiting for container: %v", err)
 			statusC <- 125
 		}
 	}()
@@ -73,9 +70,7 @@ func legacyWaitExitOrRemoved(ctx context.Context, dockerCli command.Cli, contain
 		case "die":
 			if v, ok := e.Actor.Attributes["exitCode"]; ok {
 				code, cerr := strconv.Atoi(v)
-				if cerr != nil {
-					logrus.Errorf("failed to convert exitcode '%q' to int: %v", v, cerr)
-				} else {
+				if cerr == nil {
 					exitCode = code
 				}
 			}
@@ -88,7 +83,6 @@ func legacyWaitExitOrRemoved(ctx context.Context, dockerCli command.Cli, contain
 					go func() {
 						removeErr = dockerCli.Client().ContainerRemove(ctx, containerID, types.ContainerRemoveOptions{RemoveVolumes: true})
 						if removeErr != nil {
-							logrus.Errorf("error removing container: %v", removeErr)
 							cancel() // cancel the event Q
 						}
 					}()
@@ -120,7 +114,6 @@ func legacyWaitExitOrRemoved(ctx context.Context, dockerCli command.Cli, contain
 					return
 				}
 			case err := <-errq:
-				logrus.Errorf("error getting events from daemon: %v", err)
 				return
 			}
 		}