Skip to content

add commands of how to run the test#2943

Merged
vvoland merged 1 commit into
docker:masterfrom
jimlinntu:add_test_commands_in_README
May 14, 2026
Merged

add commands of how to run the test#2943
vvoland merged 1 commit into
docker:masterfrom
jimlinntu:add_test_commands_in_README

Conversation

@jimlinntu
Copy link
Copy Markdown
Contributor

@jimlinntu jimlinntu commented Jan 23, 2021

- What I did
Add two commands on how to run the test of this repo, resolving #2935.

- How I did it
Add these commands in the README.md

- How to verify it

- Description for the changelog

Add two commands on how to run the test of this repo.

- A picture of a cute animal (not mandatory but encouraged)
🐘

Signed-off-by: Jim Lin <b04705003@ntu.edu.tw>
@thaJeztah thaJeztah force-pushed the add_test_commands_in_README branch from e87fd62 to 80ad53b Compare May 14, 2026 00:21
@thaJeztah thaJeztah added this to the 29.5.0 milestone May 14, 2026
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah requested a review from vvoland May 14, 2026 00:22
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread README.md
Run the unit test:

```
$ make -f docker.Makefile test-unit
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, we should probably make docker.Makefile the default one

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there's been some back-and-forth on that, but it's definitely awkward having to specify the makefile every time

I think the tricky one was make build, which is not expected to require docker to build (as it's used as part of building deb, rpm packages etc.

@vvoland vvoland merged commit 6f3c1ad into docker:master May 14, 2026
100 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I think README.md should provide command of how to run the test.

4 participants