Clarify that docker secret manages Swarm secrets#3309
Open
tonistiigi wants to merge 1 commit into
Open
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3309 +/- ##
=======================================
Coverage 57.99% 57.99%
=======================================
Files 302 302
Lines 21764 21764
=======================================
Hits 12621 12621
Misses 8219 8219
Partials 924 924 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker secretcommand is a swarm-specific secret implementation where secrets are stored in swarm managers and only made available to services via swarm worker agents. Unfortunately, the command was not put underdocker swarmsubcommand and therefore leads to confusion when managing other types of secrets(eg. build secrets). Make it clear that these are Swarm secrets without requiring the user to read through the whole documentation.Signed-off-by: Tonis Tiigi tonistiigi@gmail.com