Update misspelling in swarm_ca.md#3361
Conversation
Update misspelling in swarm_ca.md
Codecov Report
@@ Coverage Diff @@
## master #3361 +/- ##
=======================================
Coverage 58.02% 58.02%
=======================================
Files 302 302
Lines 21761 21761
=======================================
Hits 12626 12626
Misses 8214 8214
Partials 921 921 |
thaJeztah
left a comment
There was a problem hiding this comment.
Thank you for contributing! It appears your commit message is missing a DCO sign-off,
causing the DCO check to fail.
We require all commit messages to have a Signed-off-by line with your name
and e-mail (see "Sign your work"
in the CONTRIBUTING.md in this repository), which looks something like:
Signed-off-by: YourFirsName YourLastName <yourname@example.org>
There is no need to open a new pull request, but to fix this (and make CI pass),
you need to amend the commit(s) in this pull request, and "force push" the amended
commit.
Unfortunately, it's not possible to do so through GitHub's web UI, so this needs
to be done through the git commandline.
You can find some instructions in the output of the DCO check (which can be found
in the "checks" tab on this pull request), as well as in the Moby contributing guide.
Steps to do so "roughly" come down to:
-
Set your name and e-mail in git's configuration:
git config --global user.name "YourFirstName YourLastName" git config --global user.email "yourname@example.org"
(Make sure to use your real name (not your GitHub username/handle) and e-mail)
-
Clone your fork locally
-
Check out the branch associated with this pull request
-
Sign-off and amend the existing commit(s)
git commit --amend --no-edit --signoff
If your pull request contains multiple commits, either squash the commits (if
needed) or sign-off each individual commit. -
Force push your branch to GitHub (using the
--forceor--force-with-leaseflags) to update the pull request.
Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions!
|
included in #6980 |
Update misspelling in swarm_ca.md
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)