docs(CLAUDE.md): note that commits must be signed off (DCO)#13817
Open
ndeloof wants to merge 1 commit into
Open
docs(CLAUDE.md): note that commits must be signed off (DCO)#13817ndeloof wants to merge 1 commit into
ndeloof wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Nicolas De loof <nicolas.deloof@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds contributor guidance to ensure all commits in this repository include a DCO sign-off, aligning day-to-day contribution workflow with the project’s compliance requirements.
Changes:
- Introduces a new Git section in
CLAUDE.md. - Documents that all commits must be created/amended with
git commit --signoff(-s) to include the required DCO sign-off.
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR adds a clear and accurate Git section to CLAUDE.md documenting the DCO sign-off requirement. The added instruction correctly specifies both --signoff and its short form -s, and covers both git commit and git commit --amend. No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gitsection toCLAUDE.mdreminding contributors (and Claude Code) that all commits to this project require a DCO sign-off (git commit --signoff)Test plan
🤖 Generated with Claude Code