gha: update docs-upstream to pin workflows by sha#13834
Conversation
This workflow was updated in 56e2dba but it looks to have pinned to a version before the workflows were pinned; https://github.com/docker/docs/blob/464a44a6e72b37cf1755968477e242a5e5f6ef7d/.github/workflows/validate-upstream.yml This patch updates the workflow to a version that uses pinned actions; https://github.com/docker/docs/blob/00aefd5eae73898c4d3bcd7a6fe95a039293706b/.github/workflows/validate-upstream.yml Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
Pull request overview
Updates the docs-upstream GitHub Actions workflow to reference a newer docker/docs reusable workflow revision that includes pinned actions, aligning this repo with the “pin by SHA” security posture introduced in #13662.
Changes:
- Update
.github/workflows/docs-upstream.ymlto usedocker/docs/.github/workflows/validate-upstream.yml@00aefd5e…instead of@464a44a6….
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
No issues found in the changed code. The PR updates the pinned SHA for the reusable workflow call docker/docs/.github/workflows/validate-upstream.yml to a newer commit (00aefd5eae73898c4d3bcd7a6fe95a039293706b) where all upstream actions are themselves SHA-pinned — exactly the recommended supply-chain-security practice. No new actions or permissions are introduced.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This workflow was updated in 56e2dba but it looks to have pinned to a version before the workflows were pinned; https://github.com/docker/docs/blob/464a44a6e72b37cf1755968477e242a5e5f6ef7d/.github/workflows/validate-upstream.yml
This patch updates the workflow to a version that uses pinned actions; https://github.com/docker/docs/blob/00aefd5eae73898c4d3bcd7a6fe95a039293706b/.github/workflows/validate-upstream.yml
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did