Skip to content

Use sonnet 4.6 as default in anthropic#2786

Merged
dgageot merged 1 commit into
docker:mainfrom
rumpl:auto-anthropic
May 13, 2026
Merged

Use sonnet 4.6 as default in anthropic#2786
dgageot merged 1 commit into
docker:mainfrom
rumpl:auto-anthropic

Conversation

@rumpl
Copy link
Copy Markdown
Member

@rumpl rumpl commented May 13, 2026

Same price, better model

@rumpl rumpl requested a review from a team as a code owner May 13, 2026 13:17
Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The production-code change is correct and well-scoped — bumping DefaultModels["anthropic"] from "claude-sonnet-4-5" to "claude-sonnet-4-6".


ℹ️ Note: test file needs updating

pkg/config/auto_test.go still hardcodes "claude-sonnet-4-5" in several places that test the default model value:

Location Test
line 171 TestAutoModelConfig – "anthropic provider" subcase
line 213 TestAutoModelConfig – "gateway defaults to anthropic" subcase
line 291 TestDefaultModels – direct assert.Equal(t, "claude-sonnet-4-5", DefaultModels["anthropic"])
line 442 TestAutoModelConfig_UserDefaultModel – "empty model falls back to auto detection" subcase

These assertions depend on DefaultModels["anthropic"] returning the old value and will fail with task test as-is. (Lines 469/477 in the same file set "claude-sonnet-4-5" as an explicit user-supplied model and are unaffected — they test that user-provided models are preserved, not the default.)

@dgageot
Copy link
Copy Markdown
Member

dgageot commented May 13, 2026

@rumpl It's in the tests too

@rumpl rumpl force-pushed the auto-anthropic branch from e9f6c87 to bd596c6 Compare May 13, 2026 13:30
@rumpl
Copy link
Copy Markdown
Member Author

rumpl commented May 13, 2026

@rumpl It's in the tests too

fixed

@rumpl rumpl force-pushed the auto-anthropic branch from bd596c6 to 44177d0 Compare May 13, 2026 13:37
@rumpl
Copy link
Copy Markdown
Member Author

rumpl commented May 13, 2026

OMG HOW MANY TIMES ARE WE CHECKING FOR THIS

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
@rumpl rumpl force-pushed the auto-anthropic branch from 44177d0 to 18a29a2 Compare May 13, 2026 13:48
@dgageot dgageot merged commit accbd8c into docker:main May 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants