route mouse-wheel events to background dialogs#2787
Merged
Conversation
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The change correctly routes mouse-wheel events to background dialogs by removing the special-case pass-through that previously allowed wheel events to fall through to the chat area. The logic is sound: the background-dialog exclusion branch is cleanly removed from handleWheelCoalesced, the dialog manager's existing forwardToTop() path handles the wheel message correctly, nil-safety is maintained via dialogMgr.Open() guards, and tab navigation/click pass-through paths are unaffected. No bugs were found in the added lines.
rumpl
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a background dialog (e.g. a pending elicitation) is open, mouse-wheel events were falling through to the chat area so the user could scroll the conversation behind the dialog. They now go to the dialog itself, like every other open dialog. Tab navigation still works as before, so the wheel naturally only ever reaches the dialog of the current tab.