Skip to content

route mouse-wheel events to background dialogs #2787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgageot merged 1 commit into from
May 13, 2026
Merged

route mouse-wheel events to background dialogs #2787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions pkg/tui/dialog/dialog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@ import (
// OpenDialogMsg is sent to open a new dialog.
//
// OriginatingEvent is an optional runtime event whose presence marks the
// dialog as a background dialog. Background dialogs do not block the rest of
// the UI: tab navigation, tab-bar mouse clicks and chat scroll-wheel events
// keep working. When the user switches away from the tab that opened the
// dialog, the dialog is closed and OriginatingEvent is re-stashed in the
// supervisor so the same prompt is re-displayed when the user returns.
// dialog as a background dialog. Background dialogs do not block tab
// navigation: tab-switch keys and tab-bar mouse clicks keep working. When
// the user switches away from the tab that opened the dialog, the dialog is
// closed and OriginatingEvent is re-stashed in the supervisor so the same
// prompt is re-displayed when the user returns. Other input (including
// mouse-wheel events) is still routed to the dialog while it is on screen.
type OpenDialogMsg struct {
Model Dialog
OriginatingEvent tea.Msg
Expand All @@ -41,7 +42,7 @@ type Manager interface {
Open() bool
TopIsExitConfirmation() bool
// TopIsBackground reports whether the topmost dialog is a background
// dialog (i.e. it should not block tab navigation or chat scrolling).
// dialog (i.e. it should not block tab navigation).
TopIsBackground() bool
// TopBackgroundEvent returns the originating event of the topmost
// background dialog, or nil if the top dialog is not a background dialog
Expand Down
6 changes: 0 additions & 6 deletions pkg/tui/tui.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2093,12 +2093,6 @@ func (m *appModel) handleWheelCoalesced(msg messages.WheelCoalescedMsg) (tea.Mod
}

if m.dialogMgr.Open() {
// Background dialogs (e.g. pending elicitations) let chat-area scroll
// wheel events fall through so the user can review the conversation
// behind the dialog while the prompt waits.
if m.dialogMgr.TopIsBackground() && m.hitTestRegion(msg.Y) == regionContent {
return m.forwardChat(msg)
}
return m.forwardDialog(msg)
}

Expand Down
Loading