Skip to content

Commit 21b3f00

Browse files
committed
Makefile: Ignore SC2329
In previous versions of shellcheck, SC2317 was emitted for every line of a unused function and we're ignoring the SC2317 completely: https://github.com/docker/docker-install/blob/6e61729e66af62fd54c0b659751a431be8f90f68/Makefile#L6 We were ignoring this error due to `version_compare` being reported as a false positive. After koalaman/shellcheck@4f81dbe this was fixed and now it produces one `SC2329` for the whole function instead of multiple SC2137. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
1 parent dd09dd2 commit 21b3f00

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ VERSION?=
33
CHANNEL?=
44

55
VOLUME_MOUNTS=-v "$(CURDIR)":/v
6-
SHELLCHECK_EXCLUSIONS=$(addprefix -e, SC1091 SC1117 SC2317)
6+
SHELLCHECK_EXCLUSIONS=$(addprefix -e, SC1091 SC1117 SC2317 SC2329)
77
SHELLCHECK=docker run --rm $(VOLUME_MOUNTS) -w /v koalaman/shellcheck:stable $(SHELLCHECK_EXCLUSIONS)
88

99
ENVSUBST_VARS=LOAD_SCRIPT_COMMIT_SHA

0 commit comments

Comments
 (0)