Skip to content

Commit 8dd41ce

Browse files
integration: Remove test_create_with_links
Container links have been replaced by user-defined networks, which provide better isolation and flexibility without injecting environment variables. https://docs.docker.com/engine/network/links/ Signed-off-by: Ricardo Branco <rbranco@suse.de>
1 parent f11a2df commit 8dd41ce

File tree

1 file changed

+0
-47
lines changed

1 file changed

+0
-47
lines changed

tests/integration/api_container_test.py

Lines changed: 0 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -64,53 +64,6 @@ def test_create_with_host_pid_mode(self):
6464
assert 'PidMode' in host_config
6565
assert host_config['PidMode'] == 'host'
6666

67-
def test_create_with_links(self):
68-
res0 = self.client.create_container(
69-
TEST_IMG, 'cat',
70-
detach=True, stdin_open=True,
71-
environment={'FOO': '1'})
72-
73-
container1_id = res0['Id']
74-
self.tmp_containers.append(container1_id)
75-
76-
self.client.start(container1_id)
77-
78-
res1 = self.client.create_container(
79-
TEST_IMG, 'cat',
80-
detach=True, stdin_open=True,
81-
environment={'FOO': '1'})
82-
83-
container2_id = res1['Id']
84-
self.tmp_containers.append(container2_id)
85-
86-
self.client.start(container2_id)
87-
88-
# we don't want the first /
89-
link_path1 = self.client.inspect_container(container1_id)['Name'][1:]
90-
link_alias1 = 'mylink1'
91-
link_env_prefix1 = link_alias1.upper()
92-
93-
link_path2 = self.client.inspect_container(container2_id)['Name'][1:]
94-
link_alias2 = 'mylink2'
95-
link_env_prefix2 = link_alias2.upper()
96-
97-
res2 = self.client.create_container(
98-
TEST_IMG, 'env', host_config=self.client.create_host_config(
99-
links={link_path1: link_alias1, link_path2: link_alias2},
100-
network_mode='bridge'
101-
)
102-
)
103-
container3_id = res2['Id']
104-
self.tmp_containers.append(container3_id)
105-
self.client.start(container3_id)
106-
assert self.client.wait(container3_id)['StatusCode'] == 0
107-
108-
logs = self.client.logs(container3_id).decode('utf-8')
109-
assert f'{link_env_prefix1}_NAME=' in logs
110-
assert f'{link_env_prefix1}_ENV_FOO=1' in logs
111-
assert f'{link_env_prefix2}_NAME=' in logs
112-
assert f'{link_env_prefix2}_ENV_FOO=1' in logs
113-
11467
def test_create_with_restart_policy(self):
11568
container = self.client.create_container(
11669
TEST_IMG, ['sleep', '2'],

0 commit comments

Comments
 (0)