dhi: add guide to use in Kubernetes#23393
Merged
Merged
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LaurentGoderre
force-pushed
the
dhi-k8s
branch
2 times, most recently
from
909220f to
9ea3ac7
Compare
Contributor
craig-osterhout
left a comment
craig-osterhout
left a comment
There was a problem hiding this comment.
Thank you @LaurentGoderre. Added a few polish nits, but otherwise LGTM.
LaurentGoderre
force-pushed
the
dhi-k8s
branch
from
9ea3ac7 to
d1da4bb
Compare
Member
Author
|
@craig-osterhout all fixed! |
craig-osterhout
approved these changes
Sep 11, 2025
Contributor
|
Thanks again. Let us know whenever it's ready to merge. |
orndorffgrant
approved these changes
Sep 11, 2025
orndorffgrant
left a comment
orndorffgrant
left a comment
There was a problem hiding this comment.
This works! Just some minor suggestions. None of this is blocking.
| Alternatively, you can create the secret manually using a Personal Access Token (PAT). | ||
| Ensure the token has at least read-only access to private repositories. For Docker Hub | ||
| replace `<registry server>` with `docker.io`. | ||
|
|
||
| ```console | ||
| $ kubectl create -n <kubernetes namespace> secret docker-registry <secret name> --docker-server=<registry server> \ | ||
| --docker-username=<registry user> --docker-password=<access token> \ | ||
| --docker-email=<registry email> | ||
| ``` |
blueprismo
reviewed
Sep 12, 2025
| metadata: | ||
| name: dhi-test | ||
| namespace: <kubernetes namespace> | ||
| spec: |
Contributor
There was a problem hiding this comment.
Should we also explicitly state run as non root so we have a fail-fast safety net?
Suggested change
| spec: | |
| spec: | |
| securityContext: | |
| runAsNonRoot: true |
Member
Author
There was a problem hiding this comment.
We could but I was trying to keep the spec as minimal as possible.
LaurentGoderre
force-pushed
the
dhi-k8s
branch
from
d1da4bb to
22a6c16
Compare
LaurentGoderre
force-pushed
the
dhi-k8s
branch
from
22a6c16 to
7d6b62b
Compare
jtwils17
approved these changes
Sep 15, 2025
Member
Author
|
@craig-osterhout I think we are good to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dhi: add guide to use in Kubernetes. For now, this only covers image pull secrets.
Reviews