Skip to content

vendor: github.com/docker/model-runner v1.1.24#24473

Merged
dvdksn merged 1 commit intodocker:mainfrom
ilopezluna:update-model-runner-v1.1.24
Mar 24, 2026
Merged

vendor: github.com/docker/model-runner v1.1.24#24473
dvdksn merged 1 commit intodocker:mainfrom
ilopezluna:update-model-runner-v1.1.24

Conversation

@ilopezluna
Copy link
Copy Markdown
Contributor

Description

Update Model Runner CLI docs.
See changes in docker/model-runner@v1.1.23...v1.1.24.

VENDOR_MODULE=github.com/docker/model-runner@v1.1.24 make vendor

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 23, 2026

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit a629564
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/69c26d48ed27780008a960fd
😎 Deploy Preview https://deploy-preview-24473--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added area/cli Relates to the CLI client dependencies Vendoring, packaging updates labels Mar 23, 2026
@ilopezluna ilopezluna force-pushed the update-model-runner-v1.1.24 branch from 2ea78bf to a629564 Compare March 24, 2026 10:53
@ilopezluna ilopezluna marked this pull request as ready for review March 24, 2026 10:57
@ilopezluna ilopezluna requested a review from dvdksn as a code owner March 24, 2026 10:57
Copy link
Copy Markdown
Contributor

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR is a legitimate vendor update operation that updates github.com/docker/model-runner from v1.1.23 to v1.1.24.

Review Summary:

  • ✅ All changes are in expected locations for a vendor update (go.mod, go.sum, _vendor/)
  • ✅ No manual edits to vendored files detected
  • ✅ Changes consist of automated updates from upstream repositories
  • ✅ Follows standard Go module vendoring practices

Changed Components:

  • Model Runner CLI reference documentation (new --backend flag for uninstall-runner command)
  • Docker CLI reference documentation (typo fix: "replacment" → "replacement", new bind mount documentation)
  • Moby API documentation (v1.54 API changes, manifest summaries, network endpoint settings)

No issues found. This vendor update can be merged.

Copy link
Copy Markdown
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: needs a follow-up PR to update latest moby api version etc

Copy link
Copy Markdown
Contributor

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR is a legitimate vendor update using the official process (VENDOR_MODULE=github.com/docker/model-runner@v1.1.24 make vendor). All changes to _vendor/ directories are automated synchronizations from upstream repositories, which is the correct way to update vendored content.

Verified:

  • ✅ Changes are from automated vendor sync, not manual edits
  • ✅ PR description clearly documents the vendor command used
  • ✅ go.mod and go.sum properly track the dependency updates
  • ✅ Vendored files contain upstream disclaimers indicating they are read-only copies

Summary:
No issues found. The PR correctly updates vendored documentation from:

  • github.com/docker/model-runner → v1.1.24
  • github.com/docker/cli → v29.3.0+incompatible

Copy link
Copy Markdown
Contributor

@doringeman doringeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dvdksn dvdksn merged commit a51ae82 into docker:main Mar 24, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli Relates to the CLI client dependencies Vendoring, packaging updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants