vendor: github.com/docker/model-runner v1.1.24#24473
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2ea78bf to
a629564
Compare
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR is a legitimate vendor update operation that updates github.com/docker/model-runner from v1.1.23 to v1.1.24.
Review Summary:
- ✅ All changes are in expected locations for a vendor update (go.mod, go.sum, _vendor/)
- ✅ No manual edits to vendored files detected
- ✅ Changes consist of automated updates from upstream repositories
- ✅ Follows standard Go module vendoring practices
Changed Components:
- Model Runner CLI reference documentation (new
--backendflag foruninstall-runnercommand) - Docker CLI reference documentation (typo fix: "replacment" → "replacement", new bind mount documentation)
- Moby API documentation (v1.54 API changes, manifest summaries, network endpoint settings)
No issues found. This vendor update can be merged.
dvdksn
left a comment
There was a problem hiding this comment.
note to self: needs a follow-up PR to update latest moby api version etc
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR is a legitimate vendor update using the official process (VENDOR_MODULE=github.com/docker/model-runner@v1.1.24 make vendor). All changes to _vendor/ directories are automated synchronizations from upstream repositories, which is the correct way to update vendored content.
Verified:
- ✅ Changes are from automated vendor sync, not manual edits
- ✅ PR description clearly documents the vendor command used
- ✅ go.mod and go.sum properly track the dependency updates
- ✅ Vendored files contain upstream disclaimers indicating they are read-only copies
Summary:
No issues found. The PR correctly updates vendored documentation from:
github.com/docker/model-runner→ v1.1.24github.com/docker/cli→ v29.3.0+incompatible
Description
Update Model Runner CLI docs.
See changes in docker/model-runner@v1.1.23...v1.1.24.
Reviews