Skip to content

chore: pin Actions to commit SHA, lock npm versions, remove pull_request_target#24504

Merged
dvdksn merged 2 commits intodocker:mainfrom
dvdksn:fix/pin-actions-sha-lock-deps
Mar 24, 2026
Merged

chore: pin Actions to commit SHA, lock npm versions, remove pull_request_target#24504
dvdksn merged 2 commits intodocker:mainfrom
dvdksn:fix/pin-actions-sha-lock-deps

Conversation

@dvdksn
Copy link
Copy Markdown
Contributor

@dvdksn dvdksn commented Mar 24, 2026

🤖 Generated with Claude Code

Summary

Security hardening for GitHub Actions workflows:

  • Pin all action references to full commit SHA — replaces mutable tags (@v4, @latest, etc.) with verified commit SHAs. Mutable tags are an active supply-chain attack vector. Tag retained as inline comment for readability.
  • Lock npm exact versions — removes all ^ range prefixes from package.json. Exact versions sourced from package-lock.json; no version changes.
  • Remove pull_request_target from pr-review.yml — auto-review on PR open/ready is dropped; manual /review command via issue_comment is preserved and unaffected.
  • Disable labeler workflow — replaces pull_request_target trigger with workflow_dispatch. Workflow is kept but inert; can be re-enabled by reverting this change.

dvdksn and others added 2 commits March 24, 2026 17:16
All mutable action tags replaced with verified commit SHAs to prevent
supply-chain attacks via tag mutation. package.json ^ ranges replaced
with exact versions from package-lock.json.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pr-review: drop pull_request_target (auto-review on open/ready_for_review).
Manual /review via issue_comment is preserved and unaffected.

labeler: replace pull_request_target with workflow_dispatch to disable
automatic fork-PR labeling. Can be re-enabled by reverting this change.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@dvdksn dvdksn added agent/generated status/review Pull requests that are ready for review labels Mar 24, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 24, 2026

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 9919609
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/69c2b98e06a05a0008561221
😎 Deploy Preview https://deploy-preview-24504--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dvdksn dvdksn requested a review from a team March 24, 2026 16:19
@github-actions github-actions bot added area/release Relates to CI or deployment dependencies Vendoring, packaging updates ci ci updates labels Mar 24, 2026
Copy link
Copy Markdown
Contributor

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR implements security hardening for GitHub Actions workflows with no issues detected:

Action SHA pinning — All action references correctly pinned to full commit SHAs with tag comments for readability
npm version locking — All ^ range prefixes removed, exact versions match package-lock.json
pull_request_target removal — Correctly removed from pr-review.yml to prevent untrusted code execution
Labeler workflow disabled — Intentionally replaced trigger with workflow_dispatch (can be re-enabled if needed)

The changes follow security best practices for supply chain hardening. No bugs or issues found.

@dvdksn dvdksn merged commit 79caa49 into docker:main Mar 24, 2026
20 checks passed
@dvdksn dvdksn deleted the fix/pin-actions-sha-lock-deps branch March 24, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent/generated area/release Relates to CI or deployment ci ci updates dependencies Vendoring, packaging updates status/review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants