Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…ts in their respective home directories
…ce it contained two topics; moved domain management into provision since sso has its own instructions in setup
|
/review |
|
❌ PR Review Failed — The review agent encountered an error and could not complete the review. View logs. |
content/manuals/enterprise/security/single-sign-on/FAQs/troubleshoot-sso.md
Outdated
Show resolved
Hide resolved
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
/review |
content/manuals/enterprise/security/provisioning/troubleshoot-provisioning.md
Outdated
Show resolved
Hide resolved
|
/review |
There was a problem hiding this comment.
Assessment: 🔴 CRITICAL
This PR reorganizes SCIM and provisioning documentation but introduces multiple broken internal links that will cause 404 errors for users.
Critical issues found:
- 10 HIGH severity: Internal links missing required
/manuals/prefix - 2 HIGH severity: Broken relative links after file reorganization
- 8 MEDIUM severity: Broken links to reorganized files and deprecated paths
All issues are in the changed code and must be fixed before merging.
HIGH Severity Issues
1. Broken relative link in provision-scim.md (line 41)
The link [Just-in-Time](just-in-time.md) is broken. The just-in-time.md file is in the parent directory, not in the scim/ subdirectory.
Fix: Change to ../just-in-time.md or /manuals/enterprise/security/provisioning/just-in-time.md
2. Missing /manuals/ prefix in just-in-time.md (lines 87-89)
Three links are missing the required /manuals/ prefix:
- Line 87:
/enterprise/security/provisioning/scim/ - Line 88:
/enterprise/security/provisioning/scim/group-mapping - Line 89:
/enterprise/security/provisioning/troubleshoot-provisioning/
According to AGENTS.md, internal links must use full source paths with /manuals/ prefix (Hugo requirement).
3. Missing /manuals/ prefix in onboard.md (line 70)
/enterprise/security/provisioning/scim/group-mapping → /manuals/enterprise/security/provisioning/scim/group-mapping
4. Missing /manuals/ prefix in provision-scim.md (lines 371-372)
- Line 371:
/enterprise/security/provisioning/scim/group-mapping/ - Line 372:
/enterprise/security/provisioning/troubleshoot-provisioning/
5. Missing /manuals/ prefix in settings-management/_index.md (line 65)
/enterprise/security/domain-management/#add-and-verify-a-domain → /manuals/enterprise/security/domain-management/#add-and-verify-a-domain
6. Potentially broken relative link in just-in-time.md (line 60)
The link [SCIM enabled](scim/#enable-scim-in-docker) may be broken. Verify the anchor exists in scim/_index.md or update to scim/provision-scim.md#enable-scim-in-docker.
MEDIUM Severity Issues
7. Deprecated paths in grid links
content/manuals/admin/company/_index.md(line 33): Uses/security/for-admins/provisioning/scim/content/manuals/admin/organization/_index.md(line 33): Uses/security/for-admins/provisioning/scim/
Fix: Update to /manuals/enterprise/security/provisioning/scim/
8. Duplicate alias in auto-provisioning.md (line 8)
The alias /security/for-admins/provisioning/just-in-time/ is also used in just-in-time.md, creating a redirect conflict.
Fix: Change to /security/for-admins/provisioning/auto-provisioning/
9. Broken links in troubleshoot-sso.md (line 130)
Two links point to the old scim.md location:
/manuals/enterprise/security/provisioning/scim.md#supported-attributes/manuals/enterprise/security/provisioning/scim.md
Fix: Update to scim/provision-scim.md
10. Incorrect case and missing prefix in connect.md (line 262)
/enterprise/security/single-sign-on/faqs/troubleshoot-sso/ should be /manuals/enterprise/security/single-sign-on/FAQs/troubleshoot-sso/ (note capital FAQs)
11. Broken relative links in just-in-time.md (lines 57, 74)
Both lines have ./scim.md which no longer exists.
Fix: Update to ./scim/ or ./scim/provision-scim.md
Summary
Root cause: According to AGENTS.md, internal links in source files must use the full source path with /manuals/ prefix. The /manuals prefix is stripped only in published URLs, not in source files (Hugo requirement).
All /enterprise/ links without /manuals/ prefix will break.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Use Hugo source paths with .md or _index.md for cross-references from admin overview, organization pages, and company users. Align SSO, SCIM, roles, enforce sign-in, Settings Management, domains, billing paths, and related targets with content/manuals layout. Made-with: Cursor
Point billing FAQs, payment method, 3D Secure, and tax certificate cross-links to Hugo source paths under content/manuals/billing and subscription. Made-with: Cursor
Point Create a Docker ID to content/manuals/accounts/create-account.md. Made-with: Cursor
Use /manuals/admin/company/_index.md for Hugo ref resolution. Made-with: Cursor
Use /manuals/... and /reference/api/hub/latest.md paths for Hugo ref resolution on JIT, provision-scim, and migrate-scim. Made-with: Cursor
Use /manuals/ paths for security announcements, access tokens, JIT, FAQs, and troubleshoot; /reference/api/hub/latest.md for Hub API; repair security-announcements URL typo and Markdown link punctuation in troubleshoot-sso. Made-with: Cursor
Point domain and SSO connect anchors to /manuals/...; align CLI reference links with /reference/cli/...md forms used elsewhere in manuals. Made-with: Cursor
|
/review |
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
Found 3 broken internal links in newly added content that need correction:
1. Missing /manuals prefix (content/guides/admin-user-management/onboard.md, line 70)
[Group mapping](/enterprise/security/provisioning/scim/group-mapping)Should be:
[Group mapping](/manuals/enterprise/security/provisioning/scim/group-mapping.md)Per AGENTS.md, internal links require the full source path including /manuals.
2. Incorrect link to SCIM directory index (content/guides/admin-user-management/onboard.md, line 48)
[SCIM](/manuals/enterprise/security/provisioning/scim.md)Should be:
[SCIM](/manuals/enterprise/security/provisioning/scim/_index.md)Or simply:
[SCIM](/manuals/enterprise/security/provisioning/scim/)Per AGENTS.md, links to directory indexes should use _index.md or just the directory path.
3. Same issue in another file
The same SCIM link issue appears in other files that reference the SCIM documentation. Please search for /manuals/enterprise/security/provisioning/scim.md and update all occurrences.
All issues are in newly added content and should be fixed before merge to prevent 404 errors.
2 participants
Updating Provision section, part of freshness updates. Will add details later. 🖖
To do:
Do I need to update links with /manuals/.../..../.../ per bot, or is that an error? need to confim if this is a blocker o if i can merge as is and file another PR to fix linking