Merged
Conversation
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Contributor
Author
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR consolidates Docker Hardened Images documentation by:
- Merging the Kubernetes usage topic into the general use topic
- Removing the standalone ELS (Extended Lifecycle Support) topic
- Simplifying pull & run sections
- Adding how to use ELS variants inline
- Replacing dev multi-stage example with cross-references
Review findings:
- ✅ Redirects for deleted files (els.md, k8s.md) are correctly in place via aliases
- ✅ Content consolidation achieves the goal of simplifying documentation structure
- ✅ No issues found in the changed code
- ✅ Changes follow Docker documentation style guidelines
The changes are well-executed and improve the documentation structure by reducing redundancy and making information easier to find.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues or tickets
ENGDOCS-3222
ENGDOCS-3226
#24616 as it may cause conflicts.
Reviews