Skip to content

add EB and EiB to size#43

Open
nexustar wants to merge 1 commit intodocker:mainfrom
nexustar:EiB
Open

add EB and EiB to size#43
nexustar wants to merge 1 commit intodocker:mainfrom
nexustar:EiB

Conversation

@nexustar
Copy link
Copy Markdown

@nexustar nexustar commented Mar 15, 2023

Allow to parse units EB and EiB. I do not add ZB and YB because they are larger than int64 range

@nexustar
Copy link
Copy Markdown
Author

nexustar commented Apr 3, 2023

@thaJeztah Cloud you please take a look

@AkihiroSuda AkihiroSuda requested a review from thaJeztah May 18, 2023 01:48
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah PTAL

Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the second though, this needs some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants