Remove vLLM x86_64 NVIDIA platform warning from pull compat check

Author: ericcurtin

pkg/distribution/distribution/client.go

@@ -8,7 +8,6 @@ import (
 	"log/slog"
 	"os"
 	"path/filepath"
-	"slices"
 	"strings"
 
 	"github.com/docker/model-runner/pkg/distribution/huggingface"
@@ -22,7 +21,6 @@ import (
 	"github.com/docker/model-runner/pkg/distribution/registry"
 	"github.com/docker/model-runner/pkg/distribution/tarball"
 	"github.com/docker/model-runner/pkg/distribution/types"
-	"github.com/docker/model-runner/pkg/inference/platform"
 	"github.com/docker/model-runner/pkg/internal/utils"
 )
 
@@ -774,13 +772,6 @@ func (c *Client) GetBundle(ref string) (types.ModelBundle, error) {
 	return c.store.BundleForModel(normalizedRef)
 }
 
-func GetSupportedFormats() []types.Format {
-	if platform.SupportsVLLM() {
-		return []types.Format{types.FormatGGUF, types.FormatSafetensors, types.FormatDiffusers}
-	}
-	return []types.Format{types.FormatGGUF, types.FormatDiffusers}
-}
-
 func checkCompat(image types.ModelArtifact, log *slog.Logger, reference string, progressWriter io.Writer) error {
 	manifest, err := image.Manifest()
 	if err != nil {
@@ -797,14 +788,7 @@ func checkCompat(image types.ModelArtifact, log *slog.Logger, reference string,
 	}
 
 	if config.GetFormat() == "" {
-		log.Warn("Model format field is empty for , unable to verify format compatibility", "model", utils.SanitizeForLog(reference))
-	} else if !slices.Contains(GetSupportedFormats(), config.GetFormat()) {
-		// Write warning but continue with pull
-		log.Warn(warnUnsupportedFormat)
-		if err := progress.WriteWarning(progressWriter, warnUnsupportedFormat, oci.ModePull); err != nil {
-			log.Warn("Failed to write warning message", "error", err)
-		}
-		// Don't return an error - allow the pull to continue
+		log.Warn("Model format field is empty; unable to verify format compatibility", "model", utils.SanitizeForLog(reference))
 	}
 
 	return nil

pkg/distribution/distribution/client_test.go

@@ -24,7 +24,6 @@ import (
 	"github.com/docker/model-runner/pkg/distribution/oci/remote"
 	mdregistry "github.com/docker/model-runner/pkg/distribution/registry"
 	"github.com/docker/model-runner/pkg/distribution/registry/testregistry"
-	"github.com/docker/model-runner/pkg/inference/platform"
 )
 
 var (
@@ -434,25 +433,13 @@ func TestClientPullModel(t *testing.T) {
 			t.Fatalf("Failed to create test client: %v", err)
 		}
 
-		// Try to pull the safetensors model with a progress writer to capture warnings
 		var progressBuf bytes.Buffer
 		err = testClient.PullModel(t.Context(), testTag, &progressBuf)
 
-		// Pull should succeed on all platforms now (with a warning on non-Linux)
 		if err != nil {
 			t.Fatalf("Expected no error, got: %v", err)
 		}
 
-		if !platform.SupportsVLLM() {
-			// On non-Linux, verify that a warning was written
-			progressOutput := progressBuf.String()
-			if !strings.Contains(progressOutput, `"type":"warning"`) {
-				t.Fatalf("Expected warning message on non-Linux platforms, got output: %s", progressOutput)
-			}
-			if !strings.Contains(progressOutput, warnUnsupportedFormat) {
-				t.Fatalf("Expected warning about safetensors format, got output: %s", progressOutput)
-			}
-		}
 	})
 
 	t.Run("pull with JSON progress messages", func(t *testing.T) {

pkg/distribution/distribution/errors.go

@@ -18,5 +18,3 @@ var (
 	)
 	ErrConflict = errors.New("resource conflict")
 )
-
-const warnUnsupportedFormat = "vLLM backend currently only implemented for x86_64 NVIDIA platforms"