Merge pull request #770 from doringeman/uninstall-runner-for-deferred-backends

feat(backends): add Uninstall method to Backend interface and uninstall-backend endpoint

Author: doringeman

cmd/cli/commands/uninstall-runner.go

@@ -14,10 +14,21 @@ import (
 type cleanupOptions struct {
 	models       bool
 	removeImages bool
+	backend      string
 }
 
 // runUninstallOrStop is shared logic for uninstall-runner and stop-runner commands
 func runUninstallOrStop(cmd *cobra.Command, opts cleanupOptions) error {
+	// Deferred backend uninstall is handled via the running model runner API
+	// and works in any context (Desktop, Moby, etc.), so handle it first.
+	if opts.backend != "" {
+		if err := desktopClient.UninstallBackend(opts.backend); err != nil {
+			return fmt.Errorf("failed to uninstall %s backend: %w", opts.backend, err)
+		}
+		cmd.Printf("Uninstalled %s backend\n", opts.backend)
+		return nil
+	}
+
 	// Ensure that we're running in a supported model runner context.
 	if kind := modelRunner.EngineKind(); kind == types.ModelRunnerEngineKindDesktop {
 		if desktop.IsDesktopWSLContext(cmd.Context(), dockerCLI) {
@@ -62,18 +73,21 @@ func runUninstallOrStop(cmd *cobra.Command, opts cleanupOptions) error {
 
 func newUninstallRunner() *cobra.Command {
 	var models, images bool
+	var backend string
 	c := &cobra.Command{
 		Use:   "uninstall-runner",
 		Short: "Uninstall Docker Model Runner (Docker Engine only)",
 		RunE: func(cmd *cobra.Command, args []string) error {
 			return runUninstallOrStop(cmd, cleanupOptions{
 				models:       models,
 				removeImages: images,
+				backend:      backend,
 			})
 		},
 		ValidArgsFunction: completion.NoComplete,
 	}
 	c.Flags().BoolVar(&models, "models", false, "Remove model storage volume")
 	c.Flags().BoolVar(&images, "images", false, "Remove "+standalone.ControllerImage+" images")
+	c.Flags().StringVar(&backend, "backend", "", "Uninstall a deferred backend (e.g. vllm, diffusers)")
 	return c
 }

cmd/cli/desktop/desktop.go

@@ -895,6 +895,30 @@ func (c *Client) InstallBackend(backend string) error {
 	return nil
 }
 
+// UninstallBackend removes a backend's local installation via the model runner API.
+func (c *Client) UninstallBackend(backend string) error {
+	uninstallPath := inference.InferencePrefix + "/uninstall-backend"
+	jsonData, err := json.Marshal(struct {
+		Backend string `json:"backend"`
+	}{Backend: backend})
+	if err != nil {
+		return fmt.Errorf("error marshaling request: %w", err)
+	}
+
+	resp, err := c.doRequest(http.MethodPost, uninstallPath, bytes.NewReader(jsonData))
+	if err != nil {
+		return c.handleQueryError(err, uninstallPath)
+	}
+	defer resp.Body.Close()
+
+	if resp.StatusCode != http.StatusOK {
+		body, _ := io.ReadAll(resp.Body)
+		return fmt.Errorf("uninstall backend failed with status %s: %s", resp.Status, string(body))
+	}
+
+	return nil
+}
+
 func (c *Client) ConfigureBackend(request scheduling.ConfigureRequest) error {
 	configureBackendPath := inference.InferencePrefix + "/_configure"
 	jsonData, err := json.Marshal(request)

cmd/cli/docs/reference/docker_model_uninstall-runner.yaml

@@ -5,6 +5,15 @@ usage: docker model uninstall-runner
 pname: docker model
 plink: docker_model.yaml
 options:
+    - option: backend
+      value_type: string
+      description: Uninstall a deferred backend (e.g. vllm, diffusers)
+      deprecated: false
+      hidden: false
+      experimental: false
+      experimentalcli: false
+      kubernetes: false
+      swarm: false
     - option: images
       value_type: bool
       default_value: "false"

cmd/cli/docs/reference/model_uninstall-runner.md

@@ -5,10 +5,11 @@ Uninstall Docker Model Runner (Docker Engine only)
 
 ### Options
 
-| Name       | Type   | Default | Description                       |
-|:-----------|:-------|:--------|:----------------------------------|
-| `--images` | `bool` |         | Remove docker/model-runner images |
-| `--models` | `bool` |         | Remove model storage volume       |
+| Name        | Type     | Default | Description                                         |
+|:------------|:---------|:--------|:----------------------------------------------------|
+| `--backend` | `string` |         | Uninstall a deferred backend (e.g. vllm, diffusers) |
+| `--images`  | `bool`   |         | Remove docker/model-runner images                   |
+| `--models`  | `bool`   |         | Remove model storage volume                         |
 
 
 <!---MARKER_GEN_END-->

pkg/inference/backend.go

@@ -314,6 +314,10 @@ type Backend interface {
 	// instead load only the specified model. Backends should still respond to
 	// OpenAI API requests for other models with a 421 error code.
 	Run(ctx context.Context, socket, model string, modelRef string, mode BackendMode, config *BackendConfiguration) error
+	// Uninstall removes backend-specific local installations (e.g. files
+	// downloaded to ~/.docker/model-runner/). Backends with nothing to clean
+	// up should return nil.
+	Uninstall() error
 	// Status returns a description of the backend's state.
 	Status() string
 	// GetDiskUsage returns the disk usage of the backend.

pkg/inference/backends/diffusers/diffusers.go

@@ -264,6 +264,16 @@ func (d *diffusers) Run(ctx context.Context, socket, model string, modelRef stri
 }
 
 // Status implements inference.Backend.Status.
+// Uninstall implements inference.Backend.Uninstall.
+func (d *diffusers) Uninstall() error {
+	if err := os.RemoveAll(d.installDir); err != nil {
+		return fmt.Errorf("failed to remove diffusers install directory: %w", err)
+	}
+	d.pythonPath = ""
+	d.status = inference.FormatNotInstalled("")
+	return nil
+}
+
 func (d *diffusers) Status() string {
 	return d.status
 }

pkg/inference/backends/llamacpp/llamacpp.go

@@ -183,6 +183,11 @@ func (l *llamaCpp) Run(ctx context.Context, socket, model string, _ string, mode
 	})
 }
 
+// Uninstall implements inference.Backend.Uninstall.
+func (l *llamaCpp) Uninstall() error {
+	return nil
+}
+
 func (l *llamaCpp) Status() string {
 	return l.status
 }

pkg/inference/backends/mlx/mlx.go

@@ -147,6 +147,11 @@ func (m *mlx) Run(ctx context.Context, socket, model string, modelRef string, mo
 	})
 }
 
+// Uninstall implements inference.Backend.Uninstall.
+func (m *mlx) Uninstall() error {
+	return nil
+}
+
 func (m *mlx) Status() string {
 	return m.status
 }

pkg/inference/backends/sglang/sglang.go

@@ -176,6 +176,11 @@ func (s *sglang) Run(ctx context.Context, socket, model string, modelRef string,
 	})
 }
 
+// Uninstall implements inference.Backend.Uninstall.
+func (s *sglang) Uninstall() error {
+	return nil
+}
+
 func (s *sglang) Status() string {
 	return s.status
 }

pkg/inference/backends/vllm/vllm.go

@@ -187,6 +187,11 @@ func (v *vLLM) Run(ctx context.Context, socket, model string, modelRef string, m
 	})
 }
 
+// Uninstall implements inference.Backend.Uninstall.
+func (v *vLLM) Uninstall() error {
+	return nil
+}
+
 func (v *vLLM) Status() string {
 	return v.status
 }