Unload configs based on model ID and for both modes.#117
Merged
Conversation
Follow-up to #98. Signed-off-by: Jacob Howard <jacob.howard@docker.com>
ilopezluna
approved these changes
Jul 23, 2025
doringeman
approved these changes
Jul 23, 2025
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Oct 2, 2025
fix: align DMR URLs to consistently include trailing slash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We key configs by model ID now rather than model ref.
Also, even though we still only invoke
setRunnerConfigwithBackendModeCompletion, we should evict both modes of configuration when the model is unloaded.Follow-up to #98.